Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete confirmation bug #69

Closed

Conversation

JustinDSN
Copy link
Contributor

@JustinDSN JustinDSN commented May 16, 2019

Builds upon the solution in PR #63 to fix bug #61.

  • Changes confirm dialog from Void to Bool observable
  • True represents Yes, False represents No
  • Dismisses the dialog if disposed.

@JustinDSN
Copy link
Contributor Author

@sergdort can we get this PR reviewed and merged?

@JustinDSN
Copy link
Contributor Author

JustinDSN commented May 31, 2020

@sergdort are you interested in this patch? - I can fix the merge conflicts or close it.

@JustinDSN JustinDSN closed this Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant