Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct android makefile relative paths #46

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

pwltr
Copy link
Contributor

@pwltr pwltr commented Aug 24, 2023

This fixes relative paths to node_modules in CMakeLists.txt that caused build failure on Android.

Closes #43 #45

Tested on following system:

CMake: 3.22.1

System:
    OS: macOS 13.4.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 116.34 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.5.1 - ~/.nvm/versions/node/v18.16.0/bin/npm
    Watchman: 2023.08.14.00 - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.12.1 - /opt/homebrew/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
    Android SDK: Not Found
  IDEs:
    Android Studio: 2022.2 AI-222.4459.24.2221.9862592
    Xcode: 14.3.1/14E300c - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.20 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0 
    react-native: 0.71.7 => 0.71.7 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

@nikgraf
Copy link
Member

nikgraf commented Sep 19, 2023

Thanks @pwltr, will cut a new release tomorrow

@nikgraf nikgraf self-requested a review September 19, 2023 15:52
@nikgraf nikgraf merged commit 1e7fbb5 into serenity-kit:main Sep 19, 2023
@nikgraf
Copy link
Member

nikgraf commented Oct 2, 2023

Hey @pwltr, sorry took me a bit longer. You change broke other cases and I now added a dynamic node_modules finding solution that works for other projects as well #47

I cut a release and hopefully works as expected now

@pwltr
Copy link
Contributor Author

pwltr commented Oct 2, 2023

Hey no worries, thanks for taking a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't compile empty RN project with v1.1.0 for Android
2 participants