Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow rename with str|bool|int type for internally tagged enums #1392

Closed
wants to merge 12 commits into from
Closed

Allow rename with str|bool|int type for internally tagged enums #1392

wants to merge 12 commits into from

Commits on Sep 12, 2018

  1. Add new struct for enum variants values 

    This will enable enum variants to support in addition the type int and bool
    @NotBad4U
    NotBad4U committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    47fd94f View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2018

  1. Add a check to prevent the use of int|bool in variant name for extern… 

    …al and untagged enum
    @NotBad4U
    NotBad4U committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    bc1a59b View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2018

  1. Add serde export method to support convertion from int|bool for inter… 

    …nally tagged enums variants
    @NotBad4U
    NotBad4U committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    c9f6cae View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2018

  1. Add a new unit test for internally tagged enum renamed with an int|bool

    @NotBad4U
    NotBad4U committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    8c067d8 View commit details
    Browse the repository at this point in the history

  2. Modify the variant type name to accept int|bool|str in internally tag… 

    …ged enum
    @NotBad4U
    NotBad4U committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    268b8a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2018

  1. Modify deserialize_identifier to work with VariantNameType

    @NotBad4U
    NotBad4U committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    791822b View commit details
    Browse the repository at this point in the history

  2. Add new type and struct cases in internally tagged enum renamed unit … 

    …test
    @NotBad4U
    NotBad4U committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    c08234b View commit details
    Browse the repository at this point in the history

  3. Modify the serialization of variant new type and struct in internally… 

    … tagged enum
    @NotBad4U
    NotBad4U committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    b127a17 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2018

  1. deserialize identifiers with the correct deserializer instead of usin… 

    …g deserialize_identifier
    @NotBad4U
    NotBad4U committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    b495c5b View commit details
    Browse the repository at this point in the history

  2. Remove unreachable pattern in deserialize::visit_bool 

    Generate the true|false arms to avoid pattern true|false not covered error when the enum has only true or false arms
    @NotBad4U
    NotBad4U committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    c754e6b View commit details
    Browse the repository at this point in the history

  3. Omit visitors when we don't need them

    @NotBad4U
    NotBad4U committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    95344ca View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2018

  1. Add guard on fields when we generate the serde_deserializer 

    We verify if the len > 0 to avoid a runtime failure
    @NotBad4U
    NotBad4U committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    1d0146b View commit details
    Browse the repository at this point in the history