Feature/PAR 410 Add support for selling services #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mikel Martin <[email protected]>
…iceRegItems in GeneralSettingsRequest constructor
Co-authored-by: Mikel Martin <[email protected]>
…iceRegItems in GeneralSettingsRequest constructor
mescalantea
requested review from
m1k3lm,
MarijaIv and
luka-stanimirovic-logeecom
…thub.com:sequra/integration-core into feature/PAR-410-Add-support-for-selling-services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal?
Some merchants sell services (such as courses) instead physical products. A service has particular configurations like allowing you to delay the first payment or pay in advance as a registration. It also requires the end date of service, which can be a fixed date or a time duration expressed in ISO8601 format. This PR adds support for these features in General Settings.
References
How is it being implemented?
New properties have been defined for GeneralSettings Model and Entity. Also the related Controller, Request and Response classes have been updated to use the new attributes. Tests have been updated as well.
How is it tested?
Automatic tests
How is it going to be deployed?
Standard deployment