Static return type for fromArray method in Serrializable interface

sequra · Oct 8, 2024 · 9e0727f · 9e0727f
1 parent b419ee2
commit 9e0727f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/BusinessLogic/Domain/OrderReport/OrderReporter.php b/src/BusinessLogic/Domain/OrderReport/OrderReporter.php
@@ -56,10 +56,8 @@ public function toArray(): array
     public static function fromArray(array $array): Serializable
     {
         $entity = parent::fromArray($array);
-        // @phpstan-ignore-next-line
-        $entity->page = $array['page'];
-        // @phpstan-ignore-next-line
-        $entity->storeId = $array['storeId'];
+        $entity->page = intval($array['page']);
+        $entity->storeId = (string) $array['storeId'];
 
         return $entity;
     }

diff --git a/src/Infrastructure/Serializer/Interfaces/Serializable.php b/src/Infrastructure/Serializer/Interfaces/Serializable.php
@@ -14,7 +14,7 @@ interface Serializable extends \Serializable
      *
      * @param array<mixed> $array Data that is used to instantiate serializable object.
      *
-     * @return Serializable
+     * @return static
      *      Instance of serialized object.
      */
     public static function fromArray(array $array): Serializable;

diff --git a/src/Infrastructure/TaskExecution/AsyncBatchStarter.php b/src/Infrastructure/TaskExecution/AsyncBatchStarter.php
@@ -9,6 +9,9 @@
 use SeQura\Core\Infrastructure\TaskExecution\Interfaces\AsyncProcessService;
 use SeQura\Core\Infrastructure\TaskExecution\Interfaces\Runnable;
 
+/**
+ * @phpstan-consistent-constructor
+ */
 class AsyncBatchStarter implements Runnable
 {
     /**
@@ -76,7 +79,7 @@ public static function fromArray(array $array): Serializable
             $subBatches[] = Serializer::unserialize($subBatch);
         }
 
-        $instance = new self($array['batchSize'], $runners);
+        $instance = new static($array['batchSize'], $runners);
         $instance->subBatches = $subBatches;
         $instance->addIndex = $array['addIndex'];