Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RT-749] raise timeout error for circuit breaker #17

Merged
merged 4 commits into from
Oct 8, 2024
Merged

[RT-749] raise timeout error for circuit breaker #17

merged 4 commits into from
Oct 8, 2024

Conversation

uncoder
Copy link
Contributor

@uncoder uncoder commented Oct 8, 2024

What is the goal?

Raise Factiva::TimeoutError error for CircuitBreaker. Second attempt to deploy #13 which was reverted.

References

How is it being implemented?

Re-raise HTTP::TimeoutError while handling other errors and converting them to Failure

How is it tested?

Automatic tests

How is it going to be deployed?

Standard deployment

@uncoder uncoder requested a review from a team as a code owner October 8, 2024 09:58
github-actions[bot]
github-actions bot reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

rubocop

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 109 in 16b3abd

"variation" => {"structural" => false, "linguistic" => false, "non_linguistic" => false},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 109 in 16b3abd

"variation" => {"structural" => false, "linguistic" => false, "non_linguistic" => false},

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 114 in 16b3abd

"percentage_match" =>1.0,

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 116 in 16b3abd

"boosting_events" =>[],

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 120 in 16b3abd

"current_state" => {"timestamp" => "2022-06-22T07:41:53", "state" => "OPEN"},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 120 in 16b3abd

"current_state" => {"timestamp" => "2022-06-22T07:41:53", "state" => "OPEN"},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 121 in 16b3abd

"birthdates" => [{"day" => 17, "year" => 1951, "month" => 2}],

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 121 in 16b3abd

"birthdates" => [{"day" => 17, "year" => 1951, "month" => 2}],

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 125 in 16b3abd

"primary_name" => {"name_type" => "PRIMARY", "first_name" => "Maria Remedios", "last_name" => "Garcia Albert"},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 125 in 16b3abd

"primary_name" => {"name_type" => "PRIMARY", "first_name" => "Maria Remedios", "last_name" => "Garcia Albert"},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 135 in 16b3abd

"variation" => {"structural"=>false, "linguistic"=>false, "non_linguistic"=>false},

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 135 in 16b3abd

"variation" => {"structural"=>false, "linguistic"=>false, "non_linguistic"=>false},

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 135 in 16b3abd

"variation" => {"structural"=>false, "linguistic"=>false, "non_linguistic"=>false},

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 135 in 16b3abd

"variation" => {"structural"=>false, "linguistic"=>false, "non_linguistic"=>false},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 135 in 16b3abd

"variation" => {"structural"=>false, "linguistic"=>false, "non_linguistic"=>false},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 146 in 16b3abd

"current_state" => {"timestamp" => "2022-06-22T07:41:54", "state" => "OPEN"},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 146 in 16b3abd

"current_state" => {"timestamp" => "2022-06-22T07:41:54", "state" => "OPEN"},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 147 in 16b3abd

"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 147 in 16b3abd

"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 147 in 16b3abd

"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 147 in 16b3abd

"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 147 in 16b3abd

"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 151 in 16b3abd

"primary_name" => {"name_type" => "PRIMARY", "first_name" => "Maria Remedios", "last_name" => "Garcia Albert"},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 151 in 16b3abd

"primary_name" => {"name_type" => "PRIMARY", "first_name" => "Maria Remedios", "last_name" => "Garcia Albert"},

📝 [rubocop] <Layout/LineLength> reported by reviewdog 🐶
Line is too long. [135/128]

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 159 in 16b3abd

expect(result["data"][0]["attributes"]["matches"][0]["match_invalid_reason"]).to eq "Match excluded by filter: year_of_birth"

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 196 in 16b3abd

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 196 in 16b3abd

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 196 in 16b3abd

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/LineLength> reported by reviewdog 🐶
Line is too long. [173/128]

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 196 in 16b3abd

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 196 in 16b3abd

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 196 in 16b3abd

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 196 in 16b3abd

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

github-actions[bot]
github-actions bot reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

rubocop

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 135 in dd36735

"variation" => {"structural"=>false, "linguistic"=>false, "non_linguistic"=>false},

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 135 in dd36735

"variation" => {"structural"=>false, "linguistic"=>false, "non_linguistic"=>false},

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 135 in dd36735

"variation" => {"structural"=>false, "linguistic"=>false, "non_linguistic"=>false},

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 135 in dd36735

"variation" => {"structural"=>false, "linguistic"=>false, "non_linguistic"=>false},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 135 in dd36735

"variation" => {"structural"=>false, "linguistic"=>false, "non_linguistic"=>false},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 146 in dd36735

"current_state" => {"timestamp" => "2022-06-22T07:41:54", "state" => "OPEN"},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 146 in dd36735

"current_state" => {"timestamp" => "2022-06-22T07:41:54", "state" => "OPEN"},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 147 in dd36735

"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 147 in dd36735

"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 147 in dd36735

"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 147 in dd36735

"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 147 in dd36735

"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 151 in dd36735

"primary_name" => {"name_type" => "PRIMARY", "first_name" => "Maria Remedios", "last_name" => "Garcia Albert"},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 151 in dd36735

"primary_name" => {"name_type" => "PRIMARY", "first_name" => "Maria Remedios", "last_name" => "Garcia Albert"},

📝 [rubocop] <Layout/LineLength> reported by reviewdog 🐶
Line is too long. [135/128]

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 159 in dd36735

expect(result["data"][0]["attributes"]["matches"][0]["match_invalid_reason"]).to eq "Match excluded by filter: year_of_birth"

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 196 in dd36735

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 196 in dd36735

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 196 in dd36735

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/LineLength> reported by reviewdog 🐶
Line is too long. [173/128]

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 196 in dd36735

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 196 in dd36735

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 196 in dd36735

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 196 in dd36735

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

DavidKang
DavidKang approved these changes Oct 8, 2024
View reviewed changes
lib/factiva/monitoring.rb
@@ -134,7 +134,7 @@ def create_association(first_name:, last_name:, birth_year:, external_id:, nin:,

def add_association_to_case(case_id:, association_id:)
params = { json: case_association_body(
association_id,
association_id,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: This could be one line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was 45 offenses, I let rubocop to fix them himself

lib/factiva/monitoring.rb
@@ -153,7 +153,7 @@ def get_matches(case_id:)

def log_decision(case_id:, match_id:, comment:, state:, risk_rating:)
params = { json: log_decision_body(
comment, state, risk_rating,
comment, state, risk_rating,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: This could be one line

@uncoder uncoder merged commit f329c20 into master Oct 8, 2024
5 checks passed
@uncoder uncoder deleted the rt-749-exceptions-only branch October 8, 2024 11:10
@github-actions github-actions bot mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@DavidKang DavidKang DavidKang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uncoder @DavidKang