Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert refactoring #15

Merged
merged 2 commits into from
Oct 8, 2024
Merged

fix: revert refactoring #15

merged 2 commits into from
Oct 8, 2024

Conversation

uncoder
Copy link
Contributor

@uncoder uncoder commented Oct 8, 2024

What is the goal?

Reverts Factiva client refactoring #13

How is it being implemented?

Reverting commits

How is it tested?

Automatic tests

How is it going to be deployed?

Standard deployment

@uncoder uncoder requested a review from a team as a code owner October 8, 2024 09:51
github-actions[bot]
github-actions bot reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

rubocop

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 147 in e3375e7

"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 147 in e3375e7

"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 151 in e3375e7

"primary_name" => {"name_type" => "PRIMARY", "first_name" => "Maria Remedios", "last_name" => "Garcia Albert"},

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 151 in e3375e7

"primary_name" => {"name_type" => "PRIMARY", "first_name" => "Maria Remedios", "last_name" => "Garcia Albert"},

📝 [rubocop] <Layout/LineLength> reported by reviewdog 🐶
Line is too long. [135/128]

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 159 in e3375e7

expect(result["data"][0]["attributes"]["matches"][0]["match_invalid_reason"]).to eq "Match excluded by filter: year_of_birth"

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 184 in e3375e7

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 184 in e3375e7

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 184 in e3375e7

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/LineLength> reported by reviewdog 🐶
Line is too long. [173/128]

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 184 in e3375e7

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 184 in e3375e7

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 184 in e3375e7

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

factiva-api-client/spec/factiva/monitoring_spec.rb

Line 184 in e3375e7

expect(res["data"]["attributes"]["current_state"]).to eq({"timestamp"=>"2022-06-21T10:04:37.645", "comment"=>"False positive", "state"=>"CLEARED", "risk_rating"=>1})

📝 [rubocop] <Layout/LineLength> reported by reviewdog 🐶
Line is too long. [145/128]

factiva-api-client/spec/support/vcr_setup.rb

Line 16 in e3375e7

c.filter_sensitive_data("<SECRET_USERNAME>") { URI.encode_www_form_component(Factiva.configuration(Factiva::MONITORING_API_ACCOUNT).username) }

lib/factiva.rb
Comment on lines +4 to 5

REQUEST_API_ACCOUNT = "request_api_account"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [rubocop] <Layout/EmptyLinesAroundModuleBody> reported by reviewdog 🐶
Extra empty line detected at module body beginning.

Suggested change
REQUEST_API_ACCOUNT = "request_api_account"
REQUEST_API_ACCOUNT = "request_api_account"

lib/factiva/monitoring.rb
@stubbed_create_case = stubbed_create_case
@stubbed_create_association = stubbed_create_association
@stubbed_add_association_to_case = stubbed_add_association_to_case
@stubbed_create_case = stubbed_create_case
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Operator = should be surrounded by a single space.

Suggested change
@stubbed_create_case = stubbed_create_case
@stubbed_create_case = stubbed_create_case

lib/factiva/monitoring.rb
@stubbed_create_association = stubbed_create_association
@stubbed_add_association_to_case = stubbed_add_association_to_case
@stubbed_create_case = stubbed_create_case
@stubbed_create_association = stubbed_create_association
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Operator = should be surrounded by a single space.

Suggested change
@stubbed_create_association = stubbed_create_association
@stubbed_create_association = stubbed_create_association

lib/factiva/monitoring.rb
@stubbed_add_association_to_case = stubbed_add_association_to_case
@stubbed_create_case = stubbed_create_case
@stubbed_create_association = stubbed_create_association
@stubbed_add_association_to_case = stubbed_add_association_to_case
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Operator = should be surrounded by a single space.

Suggested change
@stubbed_add_association_to_case = stubbed_add_association_to_case
@stubbed_add_association_to_case = stubbed_add_association_to_case

lib/factiva/monitoring.rb
end

def create_association(first_name:, last_name:, birth_year:, external_id:, nin:, country_code:)
params = { json: association_body(
first_name,
first_name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [rubocop] <Layout/FirstArgumentIndentation> reported by reviewdog 🐶
Indent the first argument one step more than the start of the previous line.

Suggested change
first_name,
first_name,

spec/factiva/monitoring_spec.rb
@@ -143,21 +143,20 @@
"icon_hints" => ["SAN-PERSON", "SI-PERSON"],
"primary_country" => "SPAIN",
"is_score_boosted" => false,
"current_state" => { "timestamp" => "2022-06-22T07:41:54", "state" => "OPEN" },
"birthdates" => [{ "day" => 17, "year" => 1951, "month" => 2 }],
"current_state" => {"timestamp" => "2022-06-22T07:41:54", "state" => "OPEN"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

Suggested change
"current_state" => {"timestamp" => "2022-06-22T07:41:54", "state" => "OPEN"},
"current_state" => { "timestamp" => "2022-06-22T07:41:54", "state" => "OPEN"},

spec/factiva/monitoring_spec.rb
@@ -143,21 +143,20 @@
"icon_hints" => ["SAN-PERSON", "SI-PERSON"],
"primary_country" => "SPAIN",
"is_score_boosted" => false,
"current_state" => { "timestamp" => "2022-06-22T07:41:54", "state" => "OPEN" },
"birthdates" => [{ "day" => 17, "year" => 1951, "month" => 2 }],
"current_state" => {"timestamp" => "2022-06-22T07:41:54", "state" => "OPEN"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

Suggested change
"current_state" => {"timestamp" => "2022-06-22T07:41:54", "state" => "OPEN"},
"current_state" => {"timestamp" => "2022-06-22T07:41:54", "state" => "OPEN" },

spec/factiva/monitoring_spec.rb
"current_state" => { "timestamp" => "2022-06-22T07:41:54", "state" => "OPEN" },
"birthdates" => [{ "day" => 17, "year" => 1951, "month" => 2 }],
"current_state" => {"timestamp" => "2022-06-22T07:41:54", "state" => "OPEN"},
"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

Suggested change
"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],
"birthdates" => [{ "day"=>17, "year"=>1951, "month"=>2}],

spec/factiva/monitoring_spec.rb
"current_state" => { "timestamp" => "2022-06-22T07:41:54", "state" => "OPEN" },
"birthdates" => [{ "day" => 17, "year" => 1951, "month" => 2 }],
"current_state" => {"timestamp" => "2022-06-22T07:41:54", "state" => "OPEN"},
"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

Suggested change
"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],
"birthdates" => [{"day" => 17, "year"=>1951, "month"=>2}],

spec/factiva/monitoring_spec.rb
"current_state" => { "timestamp" => "2022-06-22T07:41:54", "state" => "OPEN" },
"birthdates" => [{ "day" => 17, "year" => 1951, "month" => 2 }],
"current_state" => {"timestamp" => "2022-06-22T07:41:54", "state" => "OPEN"},
"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [rubocop] <Layout/SpaceAroundOperators> reported by reviewdog 🐶
Surrounding space missing for operator =>.

Suggested change
"birthdates" => [{"day"=>17, "year"=>1951, "month"=>2}],
"birthdates" => [{"day"=>17, "year" => 1951, "month"=>2}],

github-actions[bot]
github-actions bot reviewed Oct 8, 2024
View reviewed changes
lib/factiva/monitoring.rb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [rubocop] <Layout/ClassStructure> reported by reviewdog 🐶
constants is supposed to appear before public_attribute_macros.

factiva-api-client/lib/factiva/monitoring.rb

Lines 12 to 17 in e3375e7

COUNTRY_IDS = {
"ES" => "SPAIN",
"FR" => "FRA",
"IT" => "ITALY",
"PT" => "PORL",
}.freeze

@uncoder uncoder merged commit 1f233f9 into master Oct 8, 2024
4 of 5 checks passed
@uncoder uncoder deleted the revert-factiva-refactoring branch October 8, 2024 09:52
@github-actions github-actions bot mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@uncoder