[FIX] CodeQL reports #3307
Merged
[FIX] CodeQL reports #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seqan-actions
added
lint
|
Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3307 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3307 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 271 271
Lines 11948 11954 +6
Branches 104 104
=======================================
+ Hits 11725 11731 +6
Misses 223 223 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
SGSSGene
requested changes
Nov 19, 2024
| unsigned_t end = start << 1u; | ||
| for (unsigned_t n = start, k = 0u; n < end && k < max_iterations; ++n, ++k) | ||
| unsigned_t end = static_cast<unsigned_t>(std::min<size_t>(start / 2u, max_iterations)); | ||
| for (unsigned_t n = start; n < end; ++n) |
There was a problem hiding this comment.
There seems to be something wrong here.
end = start * 2
but also the result of std::min seems wrong:
I expeected something like:
std::min(start, max_iterations) + start
There was a problem hiding this comment.
Yes, that was very wrong 😆
test/unit/utility/math_test.cpp
Outdated
| @@ -65,13 +65,13 @@ TYPED_TEST(unsigned_operations, ceil_log2) | |||
| for (uint8_t log2_value = 0; log2_value < seqan3::detail::bits_of<unsigned_t>; ++log2_value) | |||
| { | |||
| unsigned_t start = unsigned_t{1u} << log2_value; | |||
| unsigned_t end = start << 1u; | |||
| unsigned_t end = static_cast<unsigned_t>(std::min<size_t>(start / 2u, max_iterations)); | |||
seqan-actions
added
lint
|
BTW, reports are here https://github.com/seqan/seqan3/security/code-scanning |
SGSSGene
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all
Comparison of narrow type with wide type in loop condition