fix, doc: we don't have to talk about submodules anymore #3301
Conversation
seqan-actions
added
lint
|
Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3301 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3301 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 271 271
Lines 11948 11948
Branches 104 104
=======================================
Hits 11725 11725
Misses 223 223 ☔ View full report in Codecov by Sentry. |
| @@ -88,7 +88,7 @@ We recommend that you use CMake to build your project: | |||
|
|
|||
| Quick-Setup without CMake: | |||
|
|
|||
| * Clone the repository with submodules: `git clone --recurse-submodules https://github.com/seqan/seqan3.git` | |||
| * Clone the repository: `git clone https://github.com/seqan/seqan3.git` | |||
| * Add the following to your compiler invocation: | |||
| * the include directories of SeqAn and its dependencies | |||
| * C++20 mode | |||
There was a problem hiding this comment.
Do we even want a non-CMake example on the readme?
There was a problem hiding this comment.
Honestly? no.... I wonder if this should be replaced via a CPM, add_subdirectory and/or a find_path example.
seqan-actions
added
lint
There was a problem hiding this comment.
Let's keep it like this for now and have a look at https://github.com/seqan/seqan3/tree/main/test%2Fexternal_project.
We can add a CPM example there and auto include it in the Readme.
Since we are using CPM, we don't need to refer to submodules any more. I tried to remove all texts mentioning submodules.