-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] Remove GIT_TAG for URL download #3295
Conversation
The GIT_TAG is ignored, but it causes CPM to expect a git repository. When using CPM_SOURCE_CACHE, this leads to a warning, because CPM wants to run `git status` in the cached directory.
Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3295 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3295 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 271 271
Lines 11955 11955
Branches 104 104
=======================================
Hits 11732 11732
Misses 223 223 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we do VERSION ${SEQAN_SDSL_VERSION}
instead?
Or that would also not fit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw, the version is a hash value.... What does the hash value even mean in the case of a download only?
The URL is the archive of the commit. CPM says, that in general, |
My question wasn't clear: |
We don't really need it, except maybe for the latest library cron, where it would be harder to search+replace the versions; though we could use the local package override mechanism. As far as I know, there's not really a way to get the CPM package version/tag programmatically, at least it's not advertised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The GIT_TAG is ignored, but it causes CPM to expect a git repository. When using CPM_SOURCE_CACHE, this leads to a warning, because CPM wants to run
git status
in the cached directory.