Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Remove GIT_TAG for URL download #3295

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Oct 28, 2024

The GIT_TAG is ignored, but it causes CPM to expect a git repository. When using CPM_SOURCE_CACHE, this leads to a warning, because CPM wants to run git status in the cached directory.

The GIT_TAG is ignored, but it causes CPM to expect a git repository.
When using CPM_SOURCE_CACHE, this leads to a warning, because CPM wants
to run `git status` in the cached directory.
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Oct 28, 2024
@seqan-actions
Copy link
Member

Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3295

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (2b5641e) to head (bdfd768).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3295   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         271      271           
  Lines       11955    11955           
  Branches      104      104           
=======================================
  Hits        11732    11732           
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do VERSION ${SEQAN_SDSL_VERSION} instead?
Or that would also not fit?

Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw, the version is a hash value.... What does the hash value even mean in the case of a download only?

@eseiler
Copy link
Member Author

eseiler commented Oct 28, 2024

I just saw, the version is a hash value.... What does the hash value even mean in the case of a download only?

The URL is the archive of the commit.
More or less the same as GIT_TAG ${SEQAN_SDSL_VERSION}.
But, in contrast to GIT_TAG, submodules are not cloned, which takes quite a while for the SDSL.

CPM says, that in general, URL is faster than GIT_TAG, even though the latter is only a shallow clone.

@SGSSGene
Copy link
Contributor

My question wasn't clear:
Do we need set (SEQAN3_SDSL_VERSION 14cd017027ea742353fc5b500d1cb1d95896b77e)? are we using it anywhere?

@eseiler
Copy link
Member Author

eseiler commented Oct 28, 2024

My question wasn't clear: Do we need set (SEQAN3_SDSL_VERSION 14cd017027ea742353fc5b500d1cb1d95896b77e)? are we using it anywhere?

We don't really need it, except maybe for the latest library cron, where it would be harder to search+replace the versions; though we could use the local package override mechanism.

As far as I know, there's not really a way to get the CPM package version/tag programmatically, at least it's not advertised.

Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eseiler eseiler merged commit 2b0b60f into seqan:main Oct 28, 2024
40 checks passed
@eseiler eseiler deleted the infra/cpm_git branch October 28, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants