Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: go 1.20 compatibility #467

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: go 1.20 compatibility #467

wants to merge 5 commits into from

Conversation

nmemoto
Copy link

@nmemoto nmemoto commented Jun 16, 2023

Fixes

This PR updates the application to be compatible with go 1.20

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@nmemoto
Copy link
Author

nmemoto commented Jun 16, 2023

@nmemoto nmemoto marked this pull request as ready for review June 16, 2023 03:22
@Abonive
Copy link

Abonive commented Sep 5, 2023

Any update on this? @childish-sambino

@natiiaparicio
Copy link

When do you plan to review/approve this PR ? @childish-sambino

@porterctrlz
Copy link

What's the blocker to this being merged?

@porterctrlz
Copy link

Also runs cleanly on 1.21: https://github.com/controlzee/sendgrid-go/actions/runs/6713922883, but I'll take what I can get in terms of merged PRs

@lopezator
Copy link
Contributor

No maintenance here?

@porterctrlz
Copy link

@tiwarishubham635 would you be placed to merge stuff like this?

@matthew-raul
Copy link

This is sad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants