Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify emoji display condition #56

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

AhyoungRyu
Copy link
Collaborator

Addresses https://sendbird.atlassian.net/browse/AC-476

AS-IS

TO-BE

  1. The emoji shouldn’t be displayed on the bot welcome messages
  2. The emoji should be displayed only for the last one if the bot is sending multiple consecutive messages

@AhyoungRyu AhyoungRyu self-assigned this Sep 12, 2023
@@ -81,7 +81,7 @@ export default function ParsedBotMessageBody(props: Props) {
</BlockContainer>
);
})}
{sources.length > 0 ? (
{sources.length > 0 && enableSourceMessage ? (
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found that this condition needs to be here not on the above to make it work correctly.

@@ -50,15 +50,15 @@ export const DEFAULT_CONSTANT: Constant = {
],
},
firstMessageData: [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled this line cause I don't think it's really helpful 😅

@AhyoungRyu AhyoungRyu merged commit d8da83e into develop Sep 12, 2023
1 check passed
@AhyoungRyu AhyoungRyu deleted the feat/AC-476/emoji-expose branch September 12, 2023 08:34
Copy link
Contributor

@liamcho liamcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants