Skip to content

Commit

Permalink
remove TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
udpatil committed Oct 6, 2023
1 parent b3d359f commit 62b20e1
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions store/multiversion/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ type MultiVersionStore interface {
SetWriteset(index int, incarnation int, writeset map[string][]byte)
InvalidateWriteset(index int, incarnation int)
SetEstimatedWriteset(index int, incarnation int, writeset map[string][]byte)
// TODO: do we want to add helper functions for validations with readsets / applying writesets ?
}

type Store struct {
Expand Down Expand Up @@ -113,7 +112,7 @@ func (s *Store) SetWriteset(index int, incarnation int, writeset map[string][]by
s.txWritesets[index] = writeset
for key, value := range writeset {
s.tryInitMultiVersionItem(key)
if value == nil { // TODO: safe assumption?
if value == nil {
// delete if nil value
s.multiVersionMap[key].Delete(index, incarnation)
} else {
Expand Down Expand Up @@ -171,7 +170,6 @@ func (s *Store) Delete(index int, incarnation int, key []byte) {
var _ MultiVersionStore = (*Store)(nil)

func (s *Store) WriteLatestToStore(parentStore types.KVStore) {
// TODO: this shouldn't affect gas because the gas meter wrap happens further within transaction handling - but lets confirm
s.mtx.Lock()
defer s.mtx.Unlock()

Expand Down

0 comments on commit 62b20e1

Please sign in to comment.