[Bug Fix] getLogs endpoint should check whether or not to include cosmos Txs based on namespace #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jewei1997
approved these changes
Dec 11, 2024
philipsu522
approved these changes
Dec 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1988 +/- ##
==========================================
- Coverage 61.64% 61.55% -0.10%
==========================================
Files 365 263 -102
Lines 26178 24349 -1829
==========================================
- Hits 16138 14987 -1151
+ Misses 8967 8248 -719
- Partials 1073 1114 +41
|
yzang2019
changed the title
yzang2019
changed the title
yzang2019
changed the title
yzang2019
changed the title
philipsu522
pushed a commit
that referenced
this pull request
Dec 12, 2024
…mos Txs based on namespace (#1988) * Fix GetEthLogs: getEvmTxHashesFromBlock should exclude cosmos txs * Fix unit test * Fix test failure and add a check for synthetic logs * Fix test * Fix log * Increase fee * Add fee * Test
philipsu522
pushed a commit
that referenced
this pull request
Dec 12, 2024
…mos Txs based on namespace (#1988) * Fix GetEthLogs: getEvmTxHashesFromBlock should exclude cosmos txs * Fix unit test * Fix test failure and add a check for synthetic logs * Fix test * Fix log * Increase fee * Add fee * Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Problem:
getEvmTxHashesFromBlock currently include both the EVM and cosmos txs, so it will complain for receipt not found when querying get_ethLogs.
Solution:
Add a validation logic to check whether we should include cosmos side txs based on the namespace.
Testing performed to validate your change
Tested on archive node