🤖 Audit: Auto-update with latest upstream patches #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
reneme
reviewed
Jun 21, 2024
reneme
reviewed
Jul 2, 2024
See: randombit/botan#3887 This is a fairly minimal adaption, once the full refactoring is merged, we'll have to rewrite this more substantially. That won't happen before Botan 3.5.0, though. See also: randombit/botan#4024
FAlbertDev
force-pushed
the
audit/autoupdate
branch
from
a2331d3 to
367a052
Compare
FAlbertDev
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
I reviewed the audit and the Kyber cryptodoc updates. Both look good to me 👍
The only remark I have is not related to this specific PR.
The TODO above the Kyber cryptodoc:
.. todo::
This documentation is outdated (and potentially too detailed).
It should be updated as soon as those pull requests are merged:
* https://github.com/randombit/botan/pull/4024
Until then, I've removed some of the source links to pass CI.Is there a switch to prevent todo renderings in the release version? Otherwise, we could rephrase it to make it less technical.
Anyway, I think we should merge this PR soon, so that the bot does not push any more patches :)
(I did not look into the CI failures, though)
|
Let's merge and clean up tomorrow. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created automatically and contains the latest uncategorized patches from Botan's repository.
Typically, you will need to pull this branch (
audit/autoupdate) to categorize and audit the newly added patches. It is perfectly fine to push into this pull request and merge it after a code review.If not merged, this pull request will be updated with new patches continuously.