Add event_id into stage Pinterest events #766
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scyzoryck
approved these changes
Jul 13, 2023
scyzoryck
approved these changes
Jul 24, 2023
scyzoryck
approved these changes
Jul 31, 2023
ClaudiuBasescu
changed the title
scyzoryck
approved these changes
Aug 1, 2023
|
@varadarajan-tw - can we ask you for review of those changes, please? :) |
scyzoryck
reviewed
Aug 3, 2023
| @@ -117,7 +117,8 @@ Pinterest.prototype.createPropertyMapping = function() { | |||
| order_id: 'order_id', | |||
| coupon: 'coupon', | |||
| value: 'value', | |||
| currency: 'currency' | |||
| currency: 'currency', | |||
| messageIId: 'event_id' | |||
There was a problem hiding this comment.
Suggested change
| messageIId: 'event_id' | |
| messageId: 'event_id' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We need to add event_id property into Pinterest Tracking Pixel events. Add event codes
It should contain messageId from Segment event.
Testing not required