Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit testing failing issue #92

Merged
merged 20 commits into from
Jan 17, 2024

Conversation

janithlahirukariyawasam
Copy link
Member

@janithlahirukariyawasam janithlahirukariyawasam commented Jan 16, 2024

Purpose

The purpose of this PR is to fix #91

Goals

Goal is to fix unit testing failing issue.

Approach

Screenshots

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@janithlahirukariyawasam janithlahirukariyawasam marked this pull request as draft January 16, 2024 15:51
@janithlahirukariyawasam janithlahirukariyawasam changed the title unit testing failing issue unit testing failing issue (Under development) Jan 16, 2024
@janithlahirukariyawasam janithlahirukariyawasam changed the title unit testing failing issue (Under development) fix unit testing failing issue (Under development) Jan 16, 2024
@janithlahirukariyawasam janithlahirukariyawasam changed the title fix unit testing failing issue (Under development) Fix unit testing failing issue (Under development) Jan 16, 2024
@janithlahirukariyawasam janithlahirukariyawasam changed the title Fix unit testing failing issue (Under development) Fix unit testing failing issue Jan 17, 2024
@janithlahirukariyawasam janithlahirukariyawasam marked this pull request as ready for review January 17, 2024 08:27
@janithlahirukariyawasam
Copy link
Member Author

@anjula-sack fixed the unit test failing issue.

  1. Removed all existing test cases.
  2. Wrote unit tests for the service layer instead of routes.
  3. Used mocked repositories instead of real database.

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job @janithlahirukariyawasam, well done!!

@anjula-sack anjula-sack merged commit 465545d into sef-global:main Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix unit tests failing issue
2 participants