Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Get all mentee emails by status endpoint #81

Merged
merged 21 commits into from
Dec 24, 2023
Merged

Add Get all mentee emails by status endpoint #81

merged 21 commits into from
Dec 24, 2023

Conversation

janithlahirukariyawasam
Copy link
Member

@janithlahirukariyawasam janithlahirukariyawasam commented Nov 27, 2023 •
edited
Loading

Purpose

The purpose of this PR is to fix #44

Goals

Approach

Screenshots

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@janithlahirukariyawasam janithlahirukariyawasam changed the title add all mentee emails by status api Add all mentee emails by status api Nov 27, 2023
@janithlahirukariyawasam janithlahirukariyawasam marked this pull request as ready for review November 27, 2023 05:44
@janithlahirukariyawasam
Copy link
Member Author

@anjula-sack can you review this?

@janithlahirukariyawasam janithlahirukariyawasam changed the title Add all mentee emails by status api Add Get all mentee emails by status endpoint Nov 27, 2023
anjula-sack
anjula-sack requested changes Dec 2, 2023
View reviewed changes
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing can you check @janithlahirukariyawasam?

anjula-sack
anjula-sack approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @janithlahirukariyawasam

@anjula-sack anjula-sack merged commit 7c391bb into sef-global:main Dec 24, 2023
1 check failed
anjula-sack pushed a commit to anjula-sack/scholarx-backend that referenced this pull request Jul 23, 2024
@vishwaikon
Develop Testimonial & Success Stories Containers (sef-global#81)
e2df9be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjula-sack anjula-sack anjula-sack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Get all mentee emails endpoint (Admin)
2 participants
@janithlahirukariyawasam @anjula-sack