Implement mentor availability endpoint #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into get-all-users-endpoint
…into get-all-users-endpoint
…21/scholarx-backend into get-all-users-endpoint
|
I havent written the tests yet. Wanted to make sure the endpoint is fine. Will do once approved. Also im not sure about the route @anjula-sack |
anjula-sack
requested changes
Sep 18, 2023
src/routes/profile/profile.route.ts
Outdated
Comment on lines
15
to
19
| profileRouter.put( | ||
| '/mentor/availability', | ||
| requireAuth, | ||
| mentorAvailabilityHandler | ||
| ) |
There was a problem hiding this comment.
This should go to mentor routes @Shrenik0321
anjula-sack
requested changes
Sep 23, 2023
src/routes/admin/admin.route.test.ts
Outdated
Comment on lines
23
to
26
| const defaultUser = { | ||
| email: `test${randomString}@gmail.com`, | ||
| password: '123' | ||
| } |
There was a problem hiding this comment.
You can import this from mock.ts.
src/routes/admin/admin.route.test.ts
Outdated
Comment on lines
11
to
12
| const randomString = Math.random().toString(36) | ||
| const randomStringAdmin = Math.random().toString(36) |
There was a problem hiding this comment.
This can be removed. Check mock.ts
anjula-sack
pushed a commit
to anjula-sack/scholarx-backend
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this endpoint is for the mentor to update their availability
Goals
Approach
Screenshots
Checklist
Related PRs
Test environment
Learning