Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lastName filed as nullable in profile. add migration configura… #129

Conversation

dsmabulage
Copy link
Contributor

@dsmabulage dsmabulage commented Jul 10, 2024

Update lastName filed as nullable in profile

Purpose

The purpose of this PR is to fix #128

Goals

  • Update lastName field to be nullable in the profile entity.
  • Add migration configuration for the datasource.
  • Generate migration file to make last_name field nullable.
  • Update package.json scripts for debugging and migration.
  • Exclude migration files from the linting process.

Approach

Migration Generate

  1. Generate Migration File:

    npm run migration:generate -- src/migrations/<meaningful_name_for_migration_file>

  2. Migration Run:
    npm run migration:run

Screenshots

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix! @dsmabulage

@anjula-sack anjula-sack merged commit 0df9fb3 into sef-global:main Jul 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Login Issue with User's Family Name
3 participants