-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global key support #170
Global key support #170
Conversation
jasoncheng-jora
commented
Oct 24, 2023
- Vocab push: push custom key to Phrase
- Vocab pull: use translation of custom key
- Add Vocab CLI feature flag --error-on-no-global-key-translation
- Doc: Update README
🦋 Changeset detectedLatest commit: b7dddbd The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave it to the @askoufis @jahredhope for the full review, but this looks good so far 👍 Thanks for the comprehensive update to the tests and docs as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I've got some feedback around naming and release notes/docs, but overall the PR looks good.
@askoufis Thanks for the review. |
7ac3024
to
b7dddbd
Compare
FYI I published some snapshots of the changes on this branch here if you want to try them in an app. Just updating regular dependencies might not update all versions of the package, so you'll probably want to use EDIT: I have tested this feature out and it works how I would expect. |
@askoufis Awesome, thanks. |
@askoufis Tested in Echo web app and it works correctly. |