Pull translations from Phrase using locale name (#272)

.changeset/swift-crabs-applaud.md

@@ -0,0 +1,9 @@
+---
+'@vocab/phrase': patch
+---
+
+Fix translation issue caused by mismatched Phrase locale identifiers.
+
+Previous behaviour meant that translations were pushed using the locale name in Phrase, but Vocab was retrieving translations by locale code. Phrase locale codes and locale names are not always aligned. This would lead to Vocab searching for translations by code rather than name, often resulting in missing translations.
+
+Vocab now consistently pushes and pulls translations using Phrase’s locale name, regardless of the locale code set in Phrase.

packages/phrase/src/phrase-api.ts

@@ -99,18 +99,18 @@ export async function pullAllTranslations(
   const phraseResult = await callPhrase<
     Array<{
       key: { name: string };
-      locale: { code: string };
+      locale: { name: string };
       content: string;
     }>
   >(`translations?branch=${branch}&per_page=100`);
 
   const translations: TranslationsByLanguage = {};
 
   for (const r of phraseResult) {
-    if (!translations[r.locale.code]) {
-      translations[r.locale.code] = {};
+    if (!translations[r.locale.name]) {
+      translations[r.locale.name] = {};
     }
-    translations[r.locale.code][r.key.name] = { message: r.content };
+    translations[r.locale.name][r.key.name] = { message: r.content };
   }
 
   return translations;