-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report on test coverage #675
base: main
Are you sure you want to change the base?
Conversation
|
Buildkite.md.terminal(coverage), | ||
].join('\n\n'); | ||
|
||
await Buildkite.annotate(buildkiteOutput, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samchungy how do you feel about having this reporter support both Buildkite and GitHub 😬
If we want coverage integrations across both, it may be wasteful to define two reporters and to run renderCoverageText
twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love it but renderCoverageText
is kinda costly I guess. Even the loop processing this I guess.
Do reporters run in series? I wonder if we could store it in memory? 🤔
If we do this -> might want to rename the reporter? maybe reporters/annotate/index.ts
?
This is just the first step of dumping a coverage table out to a Buildkite annotation and GitHub check run. We can later build towards: