Skip to content

Commit

Permalink
template: Include manifest files in CODEOWNERS (#1162)
Browse files Browse the repository at this point in the history
As raised by @askoufis on Slack.
  • Loading branch information
72636c authored May 4, 2023
1 parent a888b4c commit b7d1571
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 4 deletions.
17 changes: 17 additions & 0 deletions .changeset/dry-suns-relate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
'skuba': patch
---

template: Include manifest files in CODEOWNERS

Our templates previously excluded `package.json` and `yarn.lock` from CODEOWNERS. This was intended to support advanced workflows such as auto-merging PRs and augmenting GitHub push notifications with custom tooling. However, we are reverting this configuration as it is more common for SEEKers to prefer a simpler CODEOWNERS-based workflow.

This will not affect existing projects. If you create a new project and wish to restore the previous behaviour, you can manually extend `.github/CODEOWNERS`:

```diff
* @<%- ownerName %>

+ # Configured by Renovate
+ package.json
+ yarn.lock
```
4 changes: 0 additions & 4 deletions template/base/.github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,5 +1 @@
* @<%- ownerName %>

# Configured by Renovate
package.json
yarn.lock

0 comments on commit b7d1571

Please sign in to comment.