feat: Make @mdx-js/loader an optional peer dependency #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: If importing `scoobie/webpack`, you'll need to add this optional peer dependency: ```sh yarn add '@mdx-js/loader@^1.6.22' ``` This is to avoid including dependencies which have some security vulnerabilities (CVE-2020-7753, CVE-2022-37601, CVE-2022-37599, CVE-2022-37603) if unnecessary. This is a bridge until #566
72636c
approved these changes
Oct 17, 2023
| }, | ||
| "peerDependenciesMeta": { | ||
| "@mermaid-js/mermaid-cli": { | ||
| "optional": true | ||
| }, | ||
| "@mdx-js/loader": { |
There was a problem hiding this comment.
Could consumers run into TypeScript errors if this isn't installed and they run sku lint with skipLibCheck: false?
There was a problem hiding this comment.
Ah, looks like it's only referenced in a JS Webpack file 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: If importing
scoobie/webpack, you'll need to add this optional peer dependency:yarn add '@mdx-js/loader@^1.6.22'This is to avoid including dependencies which have some security vulnerabilities (CVE-2020-7753, CVE-2022-37601, CVE-2022-37599, CVE-2022-37603) if unnecessary. This is a bridge until #566