Migrate to changesets #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72636c
reviewed
Oct 17, 2023
.github/workflows/release.yml
Outdated
| NPM_TOKEN: ${{ secrets.SEEK_OSS_CI_NPM_TOKEN }} | ||
|
|
||
| - name: Publish Storybook | ||
| run: yarn storybook:build && yarn storybook:deploy -- --ci --host-token-env-variable=GITHUB_TOKEN | ||
| env: | ||
| GITHUB_TOKEN: ${{ github.actor }}:${{ secrets.GITHUB_TOKEN }} | ||
| GITHUB_TOKEN: ${{ github.actor }}:${{ secrets.SEEK_OSS_CI_GITHUB_TOKEN }} |
There was a problem hiding this comment.
I'm guessing we may need to remove/change github.actor if we want to make this change, as the org token belongs to https://github.com/orgs/seek-oss/teams/ci.
That said, can we check if we can stick to the repo-scoped GITHUB_TOKEN for the Storybook step? (I can't quite remember at this time why it's insufficient for Changesets though!)
There was a problem hiding this comment.
I suppose if it already works with GITHUB_TOKEN it should be fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasonably blindly copied seek-oss/logger#89. Will need the token added (at a minimum)