New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seed::update deprecated #242

Merged

David-OConnor merged 3 commits into seed-rs:master from MartinKavik:seed_update_deprecated

Oct 12, 2019

Member

MartinKavik commented Oct 11, 2019

Changes

Deprecated seed::update and related entities.
Rewritten examples update_from_js and websockets.

Why

It seems that people have tendency to use seed::update + global state instead of Model. (See e.g. MVP closures kartevonmorgen/seed-quickstart#1.)
Implementation is a little bit ugly.
It requires (de)serializable Msg - it's painful in many cases.
It's confusing - should we use App::update or seed::update?
If you want to use it from JS, you have to write error-prone boilerplate.
It would make writing /scripts/pupulate_events more difficult.

MartinKavik added 3 commits

October 11, 2019 16:05


          fix(example): Rewritten update_from_js example

d57cf80


          fix(example): Rewritten websocket example

80c1ec0


          fix(lint): Fixed warnings & formatted

7416a1e

Member

David-OConnor commented Oct 12, 2019

Agree.

David-OConnor merged commit a084193 into seed-rs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet