Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoC rework ensure #740

Merged
merged 2 commits into from
Nov 26, 2024
Merged

PoC rework ensure #740

merged 2 commits into from
Nov 26, 2024

Conversation

bouskaJ
Copy link
Collaborator

@bouskaJ bouskaJ commented Nov 12, 2024

No description provided.

@bouskaJ bouskaJ requested a review from osmman November 12, 2024 13:35
@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Nov 12, 2024

@osmman WDYT?

@bouskaJ bouskaJ force-pushed the rework_ensure branch 4 times, most recently from c3847c5 to 6a93ca4 Compare November 13, 2024 10:18
osmman
osmman requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@osmman osmman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bouskaJ, the core functionality looks solid. However, I would like us to move this to a more reasonable package structure to avoid the common/utils clutter.

internal/controller/common/utils/kubernetes/common.go Outdated Show resolved Hide resolved
internal/controller/common/utils/ensure.go Outdated Show resolved Hide resolved
internal/controller/tuf/actions/deployment.go Outdated Show resolved Hide resolved
internal/controller/tuf/actions/deployment.go Outdated Show resolved Hide resolved
@bouskaJ bouskaJ requested a review from osmman November 25, 2024 11:57
osmman
osmman requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@osmman osmman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, please migrate these test scenarios for new implementation

https://github.com/securesign/secure-sign-operator/blob/main/internal/controller/common/action/base_action_test.go

@osmman
Copy link
Contributor

osmman commented Nov 25, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 25, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bouskaJ, osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Nov 26, 2024
@osmman
Copy link
Contributor

osmman commented Nov 26, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 26, 2024
@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Nov 26, 2024

/test tas-operator-e2e

@openshift-merge-bot openshift-merge-bot bot merged commit d8376f6 into main Nov 26, 2024
15 checks passed
@bouskaJ bouskaJ mentioned this pull request Nov 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osmman osmman osmman approved these changes

@JasonPowr JasonPowr Awaiting requested review from JasonPowr

@tommyd450 tommyd450 Awaiting requested review from tommyd450

Assignees

@osmman osmman

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bouskaJ @osmman