Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURESIGN-1401] Implement Fulcio cert rotation scenario #665

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[SECURESIGN-1401] Implement Fulcio cert rotation scenario #665

merged 1 commit into from
Nov 26, 2024

Conversation

bouskaJ
Copy link
Collaborator

@bouskaJ bouskaJ commented Oct 4, 2024

No description provided.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bouskaJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2024
@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Oct 4, 2024

TODO: add tuftool to the CI

@bouskaJ bouskaJ force-pushed the SECURESIGN-1401 branch 7 times, most recently from a49c319 to 848aa4e Compare October 7, 2024 08:37
@bouskaJ bouskaJ marked this pull request as ready for review October 7, 2024 09:17
@openshift-ci openshift-ci bot requested review from lance and lkatalin October 7, 2024 09:17
@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Oct 7, 2024

ready for review

@bouskaJ bouskaJ requested review from osmman and removed request for lance and lkatalin October 7, 2024 09:17
@bouskaJ bouskaJ marked this pull request as draft October 7, 2024 11:33
@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Oct 7, 2024

Test did not pass on PROD build. Need investigation

@bouskaJ bouskaJ force-pushed the SECURESIGN-1401 branch 4 times, most recently from 9d3c716 to ed1e3dd Compare November 11, 2024 10:46
@bouskaJ bouskaJ marked this pull request as ready for review November 11, 2024 11:26
@openshift-ci openshift-ci bot requested a review from JasonPowr November 11, 2024 11:26
@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Nov 11, 2024

The FBC fail because of the #665

@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Nov 12, 2024

/override Build-fbc

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 12, 2024

@bouskaJ: Overrode contexts on behalf of bouskaJ: Build-fbc

In response to this:

/override Build-fbc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bouskaJ bouskaJ force-pushed the SECURESIGN-1401 branch 3 times, most recently from baf4f64 to 5e38ae6 Compare November 13, 2024 09:53
@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Nov 13, 2024

/test tas-operator-e2e

osmman
osmman reviewed Nov 14, 2024
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
@bouskaJ bouskaJ force-pushed the SECURESIGN-1401 branch 4 times, most recently from 20a7f09 to 2bd4253 Compare November 18, 2024 08:23
@bouskaJ bouskaJ requested a review from osmman November 18, 2024 09:26
@osmman
Copy link
Contributor

osmman commented Nov 25, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 25, 2024
@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Nov 25, 2024

/cherrypick release-1.1

@openshift-cherrypick-robot
Copy link

@bouskaJ: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Nov 26, 2024

/test tas-operator-e2e

@openshift-merge-bot openshift-merge-bot bot merged commit a3f356e into main Nov 26, 2024
16 checks passed
@openshift-cherrypick-robot
Copy link

@bouskaJ: new pull request created: #773

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonPowr JasonPowr Awaiting requested review from JasonPowr

@osmman osmman Awaiting requested review from osmman

Assignees

@osmman osmman

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bouskaJ @osmman @openshift-cherrypick-robot