Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 171 #174

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Fix 171 #174

merged 2 commits into from
Feb 13, 2024

Conversation

bouskaJ
Copy link
Collaborator

@bouskaJ bouskaJ commented Feb 12, 2024

Fixes #171.

Problem:
Operator uninstall means delete of all created resources - even the Role. The Role does not exists at the operator cleanup time so resources can't be deleted.

possible solutions

  1. move the client-server to the operator-namespace and bound all resources to the operator deployment
    👎 bring mess to the openshift-operators namespace
  2. bound all CLI server resources to some cluster-wide resource
    👎 resource cleanup is not very clear, cluster wide resources stay present in the cluster even after the operator removal (so as the CLI server)
  3. Manage CLI server by securesign controller
    👎 👎 I think this is not suitable for us - the cli-server should arise with the operator installation and disappear on the operator deletion, not with the securesign resource

I choose the solution nr. 2 the CLI server is bound to the securesign CRD.

@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Feb 12, 2024

@cooktheryan @osmman WDYT?

@cooktheryan
Copy link
Collaborator

I'm good with this approach. @osmman any thoughts?

@cooktheryan cooktheryan merged commit 49724ae into main Feb 13, 2024
1 check passed
@cooktheryan cooktheryan deleted the fix_171 branch February 13, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client server resources left uninstalled after operator deletion
2 participants