Fix Terminal api missing encryption (Adyen#933)

* Add the unit test

* Add the adyen exception for missing nexoblob

* Add only the exception for the nexoblob

Adyen.Test/MockPosApiRequest.cs

@@ -111,5 +111,51 @@ public static string MockNexoJsonRequest()
                    "     \"Currency\" : \"EUR\",\r\n               \"RequestedAmount\" : 15.25 \r\n            },\r\n            \"TransactionConditions\" : {}\r\n         },\r\n      " +
                    "   \"PaymentData\" : {\"PaymentType\" : \"Normal\"}\r\n      }\r\n   }\r\n}\r\n";
         }
+        /// <summary>
+        /// Dummy terminal api json api/terminal api request without security trailer set for test
+        /// enviroment
+        /// </summary>
+        /// <returns></returns>
+        public static SaleToPOIRequest CreatePosPaymentRequestEmptySecurityTrailer()
+        {
+            var saleToPoiRequest = new SaleToPOIRequest
+            {
+                MessageHeader = new MessageHeader
+                {
+                    MessageType = MessageType.Request,
+                    MessageClass = MessageClassType.Service,
+                    MessageCategory = MessageCategoryType.Payment,
+                    SaleID = "POSSystemID12345",
+                    POIID = "MX915-284251016",
+                    ServiceID = DateTime.Now.ToString("ddHHmmss")//this should be unique
+                },
+                MessagePayload = new PaymentRequest
+                {
+                    SaleData = new SaleData
+                    {
+                        SaleTransactionID = new TransactionIdentification
+                        {
+                            TransactionID = "PosAuth",
+                            TimeStamp = DateTime.Now
+                        },
+                        TokenRequestedType = TokenRequestedType.Customer,
+                    },
+                    PaymentTransaction = new PaymentTransaction
+                    {
+                        AmountsReq = new AmountsReq
+                        {
+                            Currency = "EUR",
+                            RequestedAmount = 10100
+                        }
+                    },
+                    PaymentData = new PaymentData
+                    {
+                        PaymentType = PaymentType.Normal
+                    }
+                },
+                SecurityTrailer = null
+            };
+            return saleToPoiRequest;
+        }
     }
 }

Adyen.Test/TerminalApiPosRequestTest.cs

@@ -1,4 +1,5 @@
 using System;
+using Adyen.Exceptions;
 using Adyen.Security;
 using Adyen.Service;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
@@ -80,6 +81,25 @@ public void TestTerminalApiCardAcquisitionResponse()
             {
                 Assert.Fail();
             }
-        }      
+        }
+
+        [TestMethod]
+        public void TestTerminalApiRequestEmptySecurityTrailer()
+        {
+            try
+            {
+                var paymentRequest = MockPosApiRequest.CreatePosPaymentRequestEmptySecurityTrailer();
+                //create a mock client
+                var client = CreateMockTestClientPosLocalApiRequest("mocks/terminalapi/pospayment-no-security-trailer.json");
+                var terminalLocalApi = new TerminalLocalApi(client);
+                var configEndpoint = terminalLocalApi.Client.Config.LocalTerminalApiEndpoint;
+                var saleToPoiResponse = terminalLocalApi.TerminalRequest(paymentRequest, _encryptionCredentialDetails);
+                Assert.AreEqual(configEndpoint, @"https://_terminal_:8443/nexo/");
+            }
+            catch (Exception ex)
+            {
+                Assert.AreEqual(ex.Message,"NexoBlob is empty in the response");
+            }
+        }
     }
 }

Adyen.Test/mocks/terminalapi/pospayment-no-security-trailer.json

@@ -0,0 +1,14 @@
+{
+  "SaleToPOIResponse": {
+    "SecurityTrailer": null,
+    "MessageHeader": {
+      "ProtocolVersion": "3.0",
+      "SaleID": "John",
+      "MessageClass": "Service",
+      "MessageCategory": "Payment",
+      "ServiceID": "9739",
+      "POIID": "MX915-284251016",
+      "MessageType": "Response"
+    }
+  }
+}

Adyen/ApiSerialization/SaleToPoiMessageSecuredSerializer.cs

@@ -46,12 +46,18 @@ private void CheckForTerminalError(JObject terminalResponseJObject)
 
         private SaleToPoiMessageSecured ParseSaleToPoiMessageSecured(JToken saleToPoiMessageSecuredJToken)
         {
-            var saleToPoiMessageSecured = new SaleToPoiMessageSecured
+            var saleToPoiMessageSecured = new SaleToPoiMessageSecured();
+            saleToPoiMessageSecured.MessageHeader = saleToPoiMessageSecuredJToken.SelectToken("MessageHeader").ToObject<MessageHeader>();
+            saleToPoiMessageSecured.SecurityTrailer = saleToPoiMessageSecuredJToken.SelectToken("SecurityTrailer")
+                .ToObject<SecurityTrailer>();
+            try
             {
-                MessageHeader = saleToPoiMessageSecuredJToken.SelectToken("MessageHeader").ToObject<MessageHeader>(),
-                NexoBlob = saleToPoiMessageSecuredJToken.SelectToken("NexoBlob").ToObject<string>(),
-                SecurityTrailer = saleToPoiMessageSecuredJToken.SelectToken("SecurityTrailer").ToObject<SecurityTrailer>()
-            };
+                saleToPoiMessageSecured.NexoBlob = saleToPoiMessageSecuredJToken.SelectToken("NexoBlob").ToObject<string>();
+            }
+            catch (Exception ex)
+            {
+                throw new DeserializationException("NexoBlob is empty in the response",ex.InnerException);
+            }
 
             return saleToPoiMessageSecured;
         }