Skip to content

Commit

Permalink
Drop support for Django < 1.8
Browse files Browse the repository at this point in the history
  • Loading branch information
timgraham committed Aug 26, 2016
1 parent c20a322 commit 918fe0b
Show file tree
Hide file tree
Showing 14 changed files with 20 additions and 60 deletions.
3 changes: 0 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ python:
- "3.3"
- "3.4"
env:
- DJANGO_VERSION=1.5
- DJANGO_VERSION=1.6
- DJANGO_VERSION=1.7
- DJANGO_VERSION=1.8
# command to run tests
install: ./install_redis.sh
Expand Down
5 changes: 5 additions & 0 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ Docs can be found at http://django-redis-cache.readthedocs.org/en/latest/.
Changelog
=========

1.7.0
-----

* Drops support for Django < 1.8.

1.5.0
-----

Expand Down
5 changes: 3 additions & 2 deletions redis_cache/backends/base.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
from django.core.cache.backends.base import BaseCache, InvalidCacheBackendError
from django.core.cache.backends.base import (
BaseCache, DEFAULT_TIMEOUT, InvalidCacheBackendError,
)
from django.core.exceptions import ImproperlyConfigured

try:
Expand All @@ -10,7 +12,6 @@

from redis.connection import DefaultParser

from redis_cache.compat import DEFAULT_TIMEOUT
from redis_cache.connection import pool
from redis_cache.utils import (
CacheKey, get_servers, parse_connection_kwargs, import_class
Expand Down
3 changes: 2 additions & 1 deletion redis_cache/backends/multiple.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
from collections import defaultdict

from django.core.cache.backends.base import DEFAULT_TIMEOUT

from redis_cache.backends.base import BaseRedisCache
from redis_cache.compat import DEFAULT_TIMEOUT
from redis_cache.sharder import HashRing


Expand Down
4 changes: 2 additions & 2 deletions redis_cache/backends/single.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
from redis_cache.compat import DEFAULT_TIMEOUT

try:
import cPickle as pickle
except ImportError:
import pickle
import random

from django.core.cache.backends.base import DEFAULT_TIMEOUT

from redis_cache.backends.base import BaseRedisCache


Expand Down
8 changes: 0 additions & 8 deletions redis_cache/compat.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import sys
import django


PY3 = (sys.version_info >= (3,))
Expand All @@ -19,10 +18,3 @@
else:
bytes_type = str
from urlparse import parse_qs, urlparse


if django.VERSION[:2] >= (1, 6):
from django.core.cache.backends.base import DEFAULT_TIMEOUT as DJANGO_DEFAULT_TIMEOUT
DEFAULT_TIMEOUT = DJANGO_DEFAULT_TIMEOUT
else:
DEFAULT_TIMEOUT = None
3 changes: 0 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
"Topic :: Utilities",
"Environment :: Web Environment",
"Framework :: Django",
"Framework :: Django :: 1.5",
"Framework :: Django :: 1.6",
"Framework :: Django :: 1.7",
"Framework :: Django :: 1.8",
],
)
11 changes: 2 additions & 9 deletions tests/testapp/tests/base_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import os
import subprocess
import time
import unittest


try:
Expand All @@ -15,17 +14,13 @@

from django.core.cache import get_cache
from django.core.exceptions import ImproperlyConfigured
from django.test import TestCase
try:
from django.test import override_settings
except ImportError:
from django.test.utils import override_settings
from django.test import TestCase, override_settings

import redis

from tests.testapp.models import Poll, expensive_calculation
from redis_cache.cache import RedisCache, pool
from redis_cache.compat import DEFAULT_TIMEOUT, smart_bytes
from redis_cache.compat import smart_bytes
from redis_cache.utils import get_servers, parse_connection_kwargs


Expand Down Expand Up @@ -294,7 +289,6 @@ def test_expiration(self):
self.assertEqual(self.cache.get("expire2"), "newvalue")
self.assertEqual("expire3" in self.cache, False)

@unittest.skipIf(DEFAULT_TIMEOUT is None, "Version of django doesn't support indefinite timeouts.")
def test_set_expiration_timeout_None(self):
key, value = 'key', 'value'
self.cache.set(key, value, timeout=None)
Expand Down Expand Up @@ -558,7 +552,6 @@ def test_ttl_set_expiry(self):
ttl = self.cache.ttl('a')
self.assertAlmostEqual(ttl, 10)

@unittest.skipIf(DEFAULT_TIMEOUT is None, "Version of django doesn't support indefinite timeouts.")
def test_ttl_no_expiry(self):
self.cache.set('a', 'a', timeout=None)
ttl = self.cache.ttl('a')
Expand Down
7 changes: 1 addition & 6 deletions tests/testapp/tests/compressor_tests.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
# -*- coding: utf-8 -*-
try:
from django.test import override_settings
except ImportError:
from django.test.utils import override_settings
from django.test import TestCase

from django.test import TestCase, override_settings

from tests.testapp.tests.base_tests import BaseRedisTestCase

Expand Down
6 changes: 1 addition & 5 deletions tests/testapp/tests/master_slave_tests.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
import time

from django.test import TestCase
try:
from django.test import override_settings
except ImportError:
from django.test.utils import override_settings
from django.test import TestCase, override_settings

from redis_cache.connection import pool

Expand Down
7 changes: 1 addition & 6 deletions tests/testapp/tests/serializers_tests.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
# -*- coding: utf-8 -*-
from __future__ import unicode_literals

from django.test import TestCase
try:
from django.test import override_settings
except ImportError:
from django.test.utils import override_settings
from django.test import TestCase, override_settings

from tests.testapp.tests.base_tests import SetupMixin

Expand Down Expand Up @@ -171,4 +167,3 @@ class MSGPackSerializerTestCase(BaseSerializerTestCase):
class YAMLSerializerTestCase(BaseSerializerTestCase):
converts_tuple_to_list = False
serializes_objects = True

6 changes: 1 addition & 5 deletions tests/testapp/tests/socket_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@
from tests.testapp.tests.base_tests import BaseRedisTestCase
from tests.testapp.tests.multi_server_tests import MultiServerTests

try:
from django.test import override_settings
except ImportError:
from django.test.utils import override_settings
from django.test import TestCase
from django.test import TestCase, override_settings


LOCATION = "unix://:yadayada@/tmp/redis0.sock?db=15"
Expand Down
6 changes: 1 addition & 5 deletions tests/testapp/tests/socket_timeout_tests.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
# -*- coding: utf-8 -*-
try:
from django.test import override_settings
except ImportError:
from django.test.utils import override_settings
from django.test import TestCase
from django.test import TestCase, override_settings

from redis.exceptions import ConnectionError
from tests.testapp.tests.base_tests import SetupMixin
Expand Down
6 changes: 1 addition & 5 deletions tests/testapp/tests/tcp_tests.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
# -*- coding: utf-8 -*-
from tests.testapp.tests.base_tests import BaseRedisTestCase
from tests.testapp.tests.multi_server_tests import MultiServerTests
try:
from django.test import override_settings
except ImportError:
from django.test.utils import override_settings
from django.test import TestCase
from django.test import TestCase, override_settings

from redis_cache.cache import ImproperlyConfigured
from redis.connection import UnixDomainSocketConnection
Expand Down

0 comments on commit 918fe0b

Please sign in to comment.