Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(step-tracker): refactor step tracker #683

Merged
merged 5 commits into from
Dec 17, 2021
Merged

refactor(step-tracker): refactor step tracker #683

merged 5 commits into from
Dec 17, 2021

Conversation

kherP
Copy link
Contributor

@kherP kherP commented Dec 7, 2021 •
edited
Loading

  • revamped step tracker to support accessibility according to this guide
  • refactored css styles with BEM methodology
  • added improvements:
    • vocalization support for accessibility
    • checkmark for last step if step is more than index of last step
  • added accessibility example in documentation
  • side note: there will be no keyboard interaction in this component but the click function of this component is retained to prevent breaking changes

re #628

@kherP
refactor(step-tracker): refactor step tracker
e54db03 
- revamp step tracker by removing redundant codes

re #628
@kherP kherP added the 🚧 Refactor refactor or code changes that wouldn't add or remove a feature label Dec 7, 2021
@kherP kherP self-assigned this Dec 7, 2021
@kherP kherP requested a review from a team as a code owner December 7, 2021 09:37
@eweseong eweseong merged commit 9cfd027 into develop Dec 17, 2021
@eweseong eweseong deleted the refactor/step-tracker-accessibility branch December 17, 2021 05:50
@sebopensource
Copy link

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eweseong eweseong eweseong approved these changes

Assignees

@kherP kherP

Labels
🚧 Refactor refactor or code changes that wouldn't add or remove a feature released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kherP @sebopensource @eweseong