Skip to content

Commit

Permalink
Merge pull request #708 from sebgroup/develop
Browse files Browse the repository at this point in the history
minor release: fixes for dropdown scrollIntoView and overscroll
  • Loading branch information
mario-subo authored Jan 27, 2022
2 parents b6b8808 + ec9ceb0 commit c8f40ed
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/src/Dropdown/Dropdown.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ export const Dropdown: React.FC<DropdownProps> = React.forwardRef(

React.useEffect(() => {
// scroll the focused item into view
getOptionsRef()?.[focusedIndex]?.scrollIntoView(false);
getOptionsRef()?.[focusedIndex]?.scrollIntoView?.(false);
}, [focusedIndex, getOptionsRef]);

return (
Expand Down
1 change: 1 addition & 0 deletions lib/src/Dropdown/dropdown.scss
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@
float: none;
overflow: auto;
z-index: $zindex-popover;
overscroll-behavior: contain;

> p {
margin: 0;
Expand Down

0 comments on commit c8f40ed

Please sign in to comment.