Merge pull request #539 from sebgroup/develop

Develop
seb-oss · Mar 10, 2021 · ba4d2cf · ba4d2cf
2 parents 52d9a14 + 0ff3a2d
commit ba4d2cf
Show file tree

Hide file tree

Showing 11 changed files with 161 additions and 397 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -40,6 +40,7 @@ jobs:
         uses: coverallsapp/[email protected]
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
+          path-to-lcov: ./lib/coverage/lcov.info
         env:
           COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_TOKEN }}
 
diff --git a/docs/src/components/TechStack.tsx b/docs/src/components/TechStack.tsx
@@ -1,4 +1,5 @@
 import React from "react";
+import { withPrefix } from "gatsby";
 import pkg from "@pkg";
 import "../styles/tech-stack.scss";
 
@@ -16,7 +17,7 @@ export const TechStack: React.FC = React.memo(() => {
             <div className="col-md-4 col-12">
                 <div className="img">
                     <a href="https://reactjs.org/" target="_blank" rel="noreferrer noopener nofollow">
-                        <img className="img-fluid" src="/react.png" alt="React" />
+                        <img className="img-fluid" src={withPrefix("/react.png")} alt="React" />
                     </a>
                 </div>
                 <h3>React</h3>
@@ -25,7 +26,7 @@ export const TechStack: React.FC = React.memo(() => {
             <div className="col-md-4 col-12">
                 <div className="img">
                     <a href="https://www.typescriptlang.org/" target="_blank" rel="noreferrer noopener nofollow">
-                        <img className="img-fluid" src="/typescript.png" alt="Typescript" />
+                        <img className="img-fluid" src={withPrefix("/typescript.png")} alt="Typescript" />
                     </a>
                 </div>
                 <h3>Typescript</h3>
@@ -34,7 +35,7 @@ export const TechStack: React.FC = React.memo(() => {
             <div className="col-md-4 col-12">
                 <div className="img">
                     <a href="https://sebgroup.github.io/bootstrap/" target="_blank" rel="noreferrer noopener nofollow">
-                        <img className="img-fluid" src="/bootstrap.png" alt="Bootstrap" />
+                        <img className="img-fluid" src={withPrefix("/bootstrap.png")} alt="Bootstrap" />
                     </a>
                 </div>
                 <h3>SEB Bootstrap</h3>

diff --git a/docs/src/pages/index.tsx b/docs/src/pages/index.tsx
@@ -5,6 +5,7 @@ import { Navbar } from "../components/Navbar";
 import { Footer } from "../components/Footer";
 import { TechStack } from "../components/TechStack";
 import { httpGet } from "../utils/http";
+import { withPrefix } from "gatsby";
 import { getCommonMetaTag, initMetaConfiguration } from "../utils/meta.util";
 import AccessibilityIllustration from "../../static/illustrations/accessibility.svg";
 import AdjustmentsIllustration from "../../static/illustrations/adjustments.svg";
@@ -15,7 +16,7 @@ const designer: GithubContributor = {
     login: "boonying",
     type: "User",
     html_url: "https://www.behance.net/boonying",
-    avatar_url: "/boonying-profile.png",
+    avatar_url: withPrefix("/boonying-profile.png"),
 };
 
 export default function Home() {

diff --git a/lib/src/Carousel/Carousel.test.tsx b/lib/src/Carousel/Carousel.test.tsx
@@ -286,7 +286,9 @@ describe("Component: Carousel", () => {
         expect(element(0).classList.contains("carousel-item-left")).toBeFalsy();
 
         act(() => Simulate.mouseLeave(container.firstElementChild));
-        act(() => jest.advanceTimersByTime(1000));
+        act(() => {
+            jest.advanceTimersByTime(1000);
+        });
         expect(element(0).classList.contains("carousel-item-left")).toBeFalsy();
 
         act(() => Simulate.mouseLeave(container.firstElementChild));
@@ -312,7 +314,9 @@ describe("Component: Carousel", () => {
             );
         });
 
-        act(() => jest.advanceTimersByTime(autoplaySpeed));
+        act(() => {
+            jest.advanceTimersByTime(autoplaySpeed);
+        });
         expect(element(0).classList.contains("carousel-item-left")).toBeTruthy();
 
         jest.clearAllTimers();

diff --git a/lib/src/Datepicker/Datepicker.test.tsx b/lib/src/Datepicker/Datepicker.test.tsx
@@ -188,15 +188,10 @@ describe("Component: Datepicker", () => {
 
     it("Should use default locale when unknown locale code provided", () => {
         act(() => {
-            render(<Datepicker {...props} localeCode="sl" forceCustom />, container);
+            render(<Datepicker {...props} localeCode="%$#^%$@" forceCustom />, container);
         });
 
         const monthElement: HTMLSelectElement = container.querySelector("select.seb-datepicker-custom-month");
-        expect(monthElement.querySelectorAll("option").item(0).innerHTML.toLowerCase()).toBe("mesec");
-
-        act(() => {
-            render(<Datepicker {...props} localeCode="%$#^%$@" forceCustom />, container);
-        });
 
         expect(monthElement.querySelectorAll("option").item(0).innerHTML.toLowerCase()).toBe("month");
     });

diff --git a/lib/src/Image/Img.test.tsx b/lib/src/Image/Img.test.tsx
@@ -89,7 +89,9 @@ describe("Component: Image", () => {
             });
         });
 
-        await act(() => promise);
+        await act(async () => {
+            await promise;
+        });
         const style: string = container.firstElementChild.getAttribute("style");
         expect(style).toContain(`background-image: url(${image})`);
         expect(style).toContain(`width: 1px`);

diff --git a/lib/src/Notification/Notification.test.tsx b/lib/src/Notification/Notification.test.tsx
@@ -46,7 +46,9 @@ describe("Component: Notification", () => {
         expect(notification.classList.contains("show")).toBeTruthy();
         expect(notification.classList.contains("hide")).toBeFalsy();
 
-        act(() => jest.advanceTimersByTime(5000));
+        act(() => {
+            jest.advanceTimersByTime(5000);
+        });
 
         expect(notification.classList.contains("show")).toBeFalsy();
         expect(notification.classList.contains("hide")).toBeTruthy();
@@ -76,7 +78,9 @@ describe("Component: Notification", () => {
         expect(notification.classList.contains("show")).toBeTruthy();
         expect(notification.classList.contains("hide")).toBeFalsy();
 
-        act(() => jest.advanceTimersByTime(customTimeout));
+        act(() => {
+            jest.advanceTimersByTime(customTimeout);
+        });
 
         expect(notification.classList.contains("show")).toBeFalsy();
         expect(notification.classList.contains("hide")).toBeTruthy();

diff --git a/lib/src/Tooltip/placement.ts b/lib/src/Tooltip/placement.ts
@@ -184,7 +184,7 @@ export class OverlayPositionChecker {
      * @returns overlay coordinate
      */
     private getOverlayPositionCoord(position: ElementPosition): void {
-        const overlayRect: ClientRect = this.overlayElement.getBoundingClientRect();
+        const overlayRect: ClientRect = this.overlayElement?.getBoundingClientRect();
         const selectedPlacement: ElementPlacement = elementPlacements[position];
         if (selectedPlacement) {
             const top: number = this.getPointPosition(selectedPlacement.y);
@@ -208,8 +208,8 @@ export class OverlayPositionChecker {
      * @returns position
      */
     private getPointPosition(point: PointPositionLabel): number {
-        const referenceRect: ClientRect = this.referenceElement.getBoundingClientRect();
-        const overlayRect: ClientRect = this.overlayElement.getBoundingClientRect();
+        const referenceRect: ClientRect = this.referenceElement?.getBoundingClientRect();
+        const overlayRect: ClientRect = this.overlayElement?.getBoundingClientRect();
         let calculatedPosition: number = 0;
         switch (point) {
             case "vertical-center":

diff --git a/lib/tsconfig.json b/lib/tsconfig.json
@@ -2,23 +2,13 @@
     "compilerOptions": {
         "outDir": "dist",
         "rootDir": "src",
-        "module": "esnext",
-        "moduleResolution": "Node",
         "target": "ES5",
-        "lib": ["ES2015", "ES6", "ES2017", "DOM"],
         "jsx": "react",
         "declaration": true,
         "declarationDir": "dist",
         "sourceMap": true,
-        "importHelpers": true,
-        "noImplicitReturns": false,
-        "noImplicitThis": false,
-        "noImplicitAny": false,
-        "strictNullChecks": false,
         "esModuleInterop": true,
-        "allowSyntheticDefaultImports": true,
         "resolveJsonModule": true
     },
-    "exclude": ["coverage", "dist"],
-    "types": ["typePatches"]
+    "exclude": ["coverage", "dist"]
 }