Merge pull request #458 from sebgroup/develop

A release that mostly fixes button type issue
seb-oss · Aug 14, 2020 · 341cd72 · 341cd72
2 parents 658d609 + 9872301
commit 341cd72
Show file tree

Hide file tree

Showing 14 changed files with 567 additions and 627 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/Dropdown/Dropdown.tsx b/src/Dropdown/Dropdown.tsx
@@ -436,6 +436,7 @@ const Dropdown: React.FunctionComponent<DropdownProps> = (props: DropdownProps):
                     return (
                         <React.Fragment key={item.id}>
                             <button
+                                type="button"
                                 tabIndex={0}
                                 ref={listRefs[index]}
                                 className={`${item.className}${currentFocused === index ? " highlighted" : ""}`}

diff --git a/src/Notification/notification-style.scss b/src/Notification/notification-style.scss
@@ -57,6 +57,7 @@ $small: 12px;
         .notification-message {
             font-size: $small;
             padding-right: 18px;
+            word-break: break-word;
             user-select: none;
         }
     }

diff --git a/src/Pagination/Pagination.tsx b/src/Pagination/Pagination.tsx
@@ -102,15 +102,15 @@ export const Pagination: React.FunctionComponent<PaginationProps> = React.memo(
                         <ul className={"pagination"}>
                             {props.value !== 1 && props.useFirstAndLast && (
                                 <li className="page-item" onClick={() => props.onChange(1)}>
-                                    <button className="page-link" title={props.firstText}>
+                                    <button className="page-link" title={props.firstText} type="button">
                                         <span className="nav-action">{props.useTextNav ? (props.firstText ? props.firstText : "First") : angleDoubleLeftIcon}</span>
                                         <span className="sr-only">{props.firstText || "First"}</span>
                                     </button>
                                 </li>
                             )}
                             {props.value !== 1 && (
                                 <li className="page-item" onClick={() => props.onChange(props.value - 1)}>
-                                    <button className="page-link" title={props.previousText}>
+                                    <button className="page-link" type="button" title={props.previousText}>
                                         <span className="nav-action">{props.useTextNav ? (props.previousText ? props.previousText : "Previous") : angleLeftIcon}</span>
                                         <span className="sr-only">{props.previousText || "Previous"}</span>
                                     </button>
@@ -119,7 +119,7 @@ export const Pagination: React.FunctionComponent<PaginationProps> = React.memo(
                             {list.map((num: number) => {
                                 return (
                                     <li className={"page-item" + (props.value === num ? " active" : "")} key={num} onClick={() => props.onChange(num)} value={num}>
-                                        <button className={"page-link" + (props.value === num ? " active" : "")}>
+                                        <button className={"page-link" + (props.value === num ? " active" : "")} type="button">
                                             <span className="nav-num">{num}</span>
                                             <span className="sr-only">{num}</span>
                                         </button>
@@ -129,7 +129,7 @@ export const Pagination: React.FunctionComponent<PaginationProps> = React.memo(
 
                             {props.value !== pagingSize && (
                                 <li className="page-item" onClick={() => props.onChange(props.value + 1)}>
-                                    <button className="page-link" title={props.nextText}>
+                                    <button className="page-link" title={props.nextText} type="button">
                                         <span className="nav-action">{props.useTextNav ? (props.nextText ? props.nextText : "Next") : angleRightIcon}</span>
                                         <span className="sr-only">{props.nextText || "Next"}</span>
                                     </button>
@@ -138,7 +138,7 @@ export const Pagination: React.FunctionComponent<PaginationProps> = React.memo(
 
                             {props.value !== pagingSize && props.useFirstAndLast && (
                                 <li className="page-item" onClick={() => props.onChange(pagingSize)}>
-                                    <button className="page-link" title={props.lastText}>
+                                    <button className="page-link" title={props.lastText} type="button">
                                         <span className="nav-action">{props.useTextNav ? (props.lastText ? props.lastText : "Last") : angleDoubleRightIcon}</span>
                                         <span className="sr-only">{props.lastText || "Last"}</span>
                                     </button>

diff --git a/src/Table/Table.test.tsx b/src/Table/Table.test.tsx
@@ -276,7 +276,7 @@ describe("Component: Table", () => {
             mode: null,
         };
 
-        const selector: string = "tbody tr.parent-row td .form-group.input-box-group";
+        const selector: string = "tbody tr.parent-row td .form-group";
 
         const updatedSelectedRows: Array<TableRow> = smallData?.slice(0, 2).map((row: TableRow) => ({ ...row, selected: true }));