Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different parallel test runner to avoid ugly stack traces #112

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Use different parallel test runner to avoid ugly stack traces #112

merged 3 commits into from
Jul 8, 2024

Conversation

mroloux
Copy link
Member

@mroloux mroloux commented Jul 8, 2024 •
edited
Loading

This PR fixes stack traces that would be printed, even when the tests were successful:

Traceback (most recent call last):
	12: from /Users/mroloux/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/minitest-5.24.1/lib/minitest.rb:86:in `block in autorun'
	11: from /Users/mroloux/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/minitest-5.24.1/lib/minitest.rb:288:in `run'
	10: from /Users/mroloux/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/minitest-parallel_fork-2.0.0/lib/minitest/parallel_fork.rb:129:in `__run'
	 9: from /Users/mroloux/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/minitest-parallel_fork-2.0.0/lib/minitest/parallel_fork.rb:85:in `parallel_fork_setup_children'
	 8: from /Users/mroloux/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/minitest-parallel_fork-2.0.0/lib/minitest/parallel_fork.rb:85:in `map'
	 7: from /Users/mroloux/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/minitest-parallel_fork-2.0.0/lib/minitest/parallel_fork.rb:85:in `each'
	 6: from /Users/mroloux/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/minitest-parallel_fork-2.0.0/lib/minitest/parallel_fork.rb:85:in `times'
	 5: from /Users/mroloux/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/minitest-parallel_fork-2.0.0/lib/minitest/parallel_fork.rb:87:in `block in parallel_fork_setup_children'
	 4: from /Users/mroloux/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/minitest-parallel_fork-2.0.0/lib/minitest/parallel_fork.rb:87:in `fork'
	 3: from /Users/mroloux/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/minitest-parallel_fork-2.0.0/lib/minitest/parallel_fork.rb:95:in `block (2 levels) in parallel_fork_setup_children'
	 2: from /Users/mroloux/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/minitest-parallel_fork-2.0.0/lib/minitest/parallel_fork.rb:54:in `parallel_fork_data_to_marshal'
	 1: from /Users/mroloux/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/minitest-parallel_fork-2.0.0/lib/minitest/parallel_fork.rb:54:in `map'

@mroloux mroloux merged commit e0f0fb0 into master Jul 8, 2024
2 checks passed
@mroloux mroloux deleted the matti/use-different-paralllel-test-runner branch July 8, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schaloner schaloner Awaiting requested review from schaloner

@bverbeken bverbeken Awaiting requested review from bverbeken

@PabloNeirotti PabloNeirotti Awaiting requested review from PabloNeirotti

@mortendevold mortendevold Awaiting requested review from mortendevold

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mroloux