When key is not found when fetching a specific event report, empty ar…

…ray is returned. This is consistent with the empty array that's returned when there are no objects on the chart, and a general report is requested.
seatsio · Nov 21, 2018 · d44ccc8 · d44ccc8
1 parent 383b635
commit d44ccc8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/Reports/EventReports.php b/src/Reports/EventReports.php
@@ -148,7 +148,7 @@ private static function mapMultiValuedReport($json, $filter)
         if (array_key_exists($filter, $result)) {
             return $result[$filter];
         }
-        return null;
+        return [];
     }
 
     private static function reportUrl($reportType, $eventKey, $filter)

diff --git a/tests/EventReports/EventReportTest.php b/tests/EventReports/EventReportTest.php
@@ -74,6 +74,15 @@ public function testByStatus()
         self::assertCount(31, $report[ObjectStatus::$FREE]);
     }
 
+    public function testByStatus_emptyChart()
+    {
+        $chartKey = $this->seatsioClient->charts->create()->key;
+        $event = $this->seatsioClient->events->create($chartKey);
+
+        $report = $this->seatsioClient->eventReports->byStatus($event->key);
+        self::assertEquals([], $report);
+    }
+
     public function testBySpecificStatus()
     {
         $chartKey = $this->createTestChart();
@@ -92,7 +101,7 @@ public function testBySpecificNonExistingStatus()
         $event = $this->seatsioClient->events->create($chartKey);
 
         $report = $this->seatsioClient->eventReports->byStatus($event->key, "lolzor");
-        self::assertNull($report);
+        self::assertEquals([], $report);
     }
 
     public function testByCategoryLabel()