Don’t check for failure by looking at the NSError

As per Cocoa convention, check the return value, not the NSError.
seanm · Jul 22, 2015 · f95d84b · f95d84b
1 parent f303720
commit f95d84b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/MiscMerge/MiscMergeTemplate.m b/MiscMerge/MiscMergeTemplate.m
@@ -136,7 +136,7 @@ - (NSString *) contentsOfFileWithName:(NSString *)filename {
                                                      encoding:NSUTF8StringEncoding
                                                         error:&error];
 
-    if (error != nil) {
+    if (fileString == nil) {
         NSLog(@"%@: Could not read template file %@ because %@", [self class], filename, [error localizedDescription]);   
     }
     return fileString;

diff --git a/mogenerator.m b/mogenerator.m
@@ -823,7 +823,7 @@ - (void)setModel:(NSString*)momOrXCDataModelFilePath {
             // Cool, the model is in the Xcode 4.0+ format, we can compile it ourselves.
             NSError *compileError = nil;
             momFilePath = [NSManagedObjectModel compileModelAtPath:momOrXCDataModelFilePath inDirectory:NSTemporaryDirectory() error:&compileError];
-            if (compileError) {
+            if (momFilePath == nil) {
                 NSLog(@"Error: %@", [compileError localizedDescription]);
             }
             assert(momFilePath);