Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 通过将日志上传改为异步改善竞争问题 #1063

Merged
merged 2 commits into from
Oct 15, 2024
Merged

fix: 通过将日志上传改为异步改善竞争问题 #1063

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c721bad
fix:缓解#1034。
PaienNate Oct 14, 2024
328a389
fix: 只保留log end的协程，同时添加注释
PaienNate Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dice/ext_log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,8 @@ func RegisterBuiltinExtLog(self *Dice) {
group.UpdatedAtTime = time.Now().Unix()

time.Sleep(time.Duration(0.3 * float64(time.Second)))
getAndUpload(group.GroupID, group.LogCurName)
// Note: 2024-10-15 经过简单测试，似乎能缓解#1034的问题，但无法根本解决。
go getAndUpload(group.GroupID, group.LogCurName)
group.LogCurName = ""
group.UpdatedAtTime = time.Now().Unix()
return CmdExecuteResult{Matched: true, Solved: true}
Expand Down
Loading