Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only apply edge mass flux adjustment to corners once #260

Merged
merged 1 commit into from
Sep 4, 2024
Merged

only apply edge mass flux adjustment to corners once #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions Source/TimeIntegration/REMORA_update_massflux_3d.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,19 +84,14 @@ REMORA::update_massflux_3d (const Box& bx,
DC(i,j,-1) = 1.0_rt / DC(i,j,-1);
CF(i,j,0) = DC(i,j,-1) * (CF(i,j,0) - Dphi_avg1(i,j,0));

// In order to agree with ROMS on the boundaries, the corner points shouldn't actually
// be updated with CF for clamped E/W, wall N/S boundaries. This doesn't seem to affect
// the interior valid points, though
for (int k=0; k<=N; k++) {
if (i == dlo.x-joff && !is_periodic_in_x) {
phi(i,j,k,nnew) -= CF(i,j,0);
phi(i,j,k,nnew) *= msk(i,j,0);
} else if (i == dhi.x+1 && !is_periodic_in_x) {
phi(i,j,k,nnew) -= CF(i,j,0);
phi(i,j,k,nnew) *= msk(i,j,0);
}

if (j == dlo.y-ioff && !is_periodic_in_y) {
} else if (j == dlo.y-ioff && !is_periodic_in_y) {
phi(i,j,k,nnew) -= CF(i,j,0);
phi(i,j,k,nnew) *= msk(i,j,0);
} else if (j == dhi.y+1 && !is_periodic_in_y) {
Expand Down
Loading