Merge pull request #260 from hklion/adjust_corners

only apply edge mass flux adjustment to corners once
seahorce-scidac · Sep 4, 2024 · e3d9e45 · e3d9e45
2 parents 1ed6cd8 + 9f0d9ef
commit e3d9e45
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/Source/TimeIntegration/REMORA_update_massflux_3d.cpp b/Source/TimeIntegration/REMORA_update_massflux_3d.cpp
@@ -84,19 +84,14 @@ REMORA::update_massflux_3d (const Box& bx,
         DC(i,j,-1) = 1.0_rt / DC(i,j,-1);
         CF(i,j,0)  = DC(i,j,-1) * (CF(i,j,0) - Dphi_avg1(i,j,0));
 
-        // In order to agree with ROMS on the boundaries, the corner points shouldn't actually
-        // be updated with CF for clamped E/W, wall N/S boundaries. This doesn't seem to affect
-        // the interior valid points, though
         for (int k=0; k<=N; k++) {
             if (i == dlo.x-joff && !is_periodic_in_x) {
                 phi(i,j,k,nnew) -= CF(i,j,0);
                 phi(i,j,k,nnew) *= msk(i,j,0);
             } else if (i == dhi.x+1 && !is_periodic_in_x) {
                 phi(i,j,k,nnew) -= CF(i,j,0);
                 phi(i,j,k,nnew) *= msk(i,j,0);
-            }
-
-            if (j == dlo.y-ioff && !is_periodic_in_y) {
+            } else if (j == dlo.y-ioff && !is_periodic_in_y) {
                 phi(i,j,k,nnew) -= CF(i,j,0);
                 phi(i,j,k,nnew) *= msk(i,j,0);
             } else if (j == dhi.y+1 && !is_periodic_in_y) {