Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/264 - Support drag and drop of calendar events closes #264 #270

Merged
merged 6 commits into from
Apr 22, 2020

Conversation

Minusome
Copy link
Contributor

Demo.

  • Support drag-and-drop of calendar events using dev-express DragDropProvider
  • Support resizing of calendar events
  • Events updated on server side
  • Reminder-date updated based on new start-date
    (note this means if you move an event which has already fired off a reminder, a new reminder may be fired off based on the new start date. This is expected behaviour for now.)

ezgif-3-05edf402456f

  • The pull request is complete according to the following criteria:
    • Acceptance criteria have been met
    • The documentation is kept up-to-date
    • Comprehensive tests (if applicable) have been generated and all pass.
    • The pull request describes the changes that have been made, and enough information is present in the description for any developer to understand what has changed
    • Commits have been squashed (or will be on merge).
    • The branch name is descriptive and follows the pull request title format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
    • The pull request title is of the following format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
    • The description uses github syntax to link to the issue. E,g Resolves se701g2/Doto#{Number}
    • At least two reviewers assigned. One of which must be the assigner of the issue.
    • If there are merge conflicts, run git rebase as opposed to git merge with master.

@Minusome Minusome linked an issue Apr 21, 2020 that may be closed by this pull request
@Minusome Minusome self-assigned this Apr 21, 2020
Copy link
Contributor

@KimberleyEvans-Parker KimberleyEvans-Parker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, makes it a lot nicer to drag the boxes around.

It doesn't look like you update the task duration if the length gets changed though. While this doesn't affect anything currently, it might affect the edit PR.

I also noticed that if you drag an item to a later time, then add a new one, it will just get added onto the end of the last task rather than going before it where there is free time. This will probably be better as a new issue (bug) though.

Copy link
Contributor

@rmoradc rmoradc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drag n Drop functionality is really nice!

Seems to be a bug where if you add a new task after dragging tasks around that new task is grouped with the last dragged task regardless of what date and time you give it.

I think this is what Kimberely was talking about so might be better as a new bug issue?

@Minusome Minusome closed this Apr 21, 2020
@Minusome Minusome reopened this Apr 21, 2020
@Minusome
Copy link
Contributor Author

Minusome commented Apr 21, 2020

Whoops, ignore accidental delete.

@KimberleyEvans-Parker and @rmoradc thanks for the comments.

I will recompute the duration and sort the tasks by startdate and see if that fixes the issues.

Update:

@rmoradc The bug you mentioned should now be fixed.
@KimberleyEvans-Parker The duration is now correctly set. The ordering bug seems to be present on the master branch so I think its a problem with upstream TaskScheduler (in fact, i'm pretty sure its to do with the dueDate property). I will create a separate issue for this.

See #274.

@Kalashnikkov
Copy link
Contributor

Hey @Minus20Five I appreciate the changes you've made!

I was working on issue #224 and it seems like when this is pushed through, I could add functionality extending this PR onto mine. Thoughts?

@Minusome
Copy link
Contributor Author

Hey @Minus20Five I appreciate the changes you've made!

I was working on issue #224 and it seems like when this is pushed through, I could add functionality extending this PR onto mine. Thoughts?

If you decide to implement recurring tasks I would recommend following the dev express API. Theres also a built-in component to edit recurring tasks.

Copy link
Contributor

@KimberleyEvans-Parker KimberleyEvans-Parker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adressing the feedback, nice work!

@Minusome Minusome merged commit 7f6b3b7 into se701g2:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support drag and drop of calendar events
4 participants