-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue/264 - Support drag and drop of calendar events closes #264 #270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, makes it a lot nicer to drag the boxes around.
It doesn't look like you update the task duration if the length gets changed though. While this doesn't affect anything currently, it might affect the edit PR.
I also noticed that if you drag an item to a later time, then add a new one, it will just get added onto the end of the last task rather than going before it where there is free time. This will probably be better as a new issue (bug) though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drag n Drop functionality is really nice!
Seems to be a bug where if you add a new task after dragging tasks around that new task is grouped with the last dragged task regardless of what date and time you give it.
I think this is what Kimberely was talking about so might be better as a new bug issue?
Whoops, ignore accidental delete. @KimberleyEvans-Parker and @rmoradc thanks for the comments. I will recompute the duration and sort the tasks by startdate and see if that fixes the issues. Update: @rmoradc The bug you mentioned should now be fixed. See #274. |
Hey @Minus20Five I appreciate the changes you've made! I was working on issue #224 and it seems like when this is pushed through, I could add functionality extending this PR onto mine. Thoughts? |
If you decide to implement recurring tasks I would recommend following the dev express API. Theres also a built-in component to edit recurring tasks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adressing the feedback, nice work!
Demo.
(note this means if you move an event which has already fired off a reminder, a new reminder may be fired off based on the new start date. This is expected behaviour for now.)