-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/232 Cannot add a new task on a selected date #263
Conversation
Fixed bug: can't add task on a selected date se701g2#232
@preetpatel could you have a look at this please, I believe you recently changed this logic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, questionable about the comprehensive testing
to be done, but if you can verify via a screenshot or something that'll be good! Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the idea of the task manager was to put in the tasks in the earliest coming up free time so that you could complete the task as early as possible. Correct me if I'm wrong, but right now this PR is looking like it gets added after the due date and time of the task - not particularly helpful if you have an asignment due then.
Maybe it would be better to add in another input stating the start after date, specifying that you're only able to start the task after this date (so if I could only start it tomorrow, I'd specify tomorrow in the start after input and the task would then be made at that time
I genuinely misunderstood the application and perhaps the related issue could be improved, my bad. I'm thinking of adding an extra field of earliest start time that would fulfill the same spirit of the related issue. I have created the new issue at #268 |
closes #232