Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/232 Cannot add a new task on a selected date #263

Closed
wants to merge 4 commits into from

Conversation

nikotj1
Copy link
Contributor

@nikotj1 nikotj1 commented Apr 20, 2020

closes #232

  • The pull request is complete according to the following criteria:
    • Acceptance criteria have been met
    • The documentation is kept up-to-date
    • Comprehensive tests (if applicable) have been generated and all pass.
    • The pull request describes the changes that have been made, and enough information is present in the description for any developer to understand what has changed
    • Commits have been squashed (or will be on merge).
    • The branch name is descriptive and follows the pull request title format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
    • The pull request title is of the following format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
    • The description uses github syntax to link to the issue. E,g Resolves se701g2/Doto#{Number}
    • At least two reviewers assigned. One of which must be the assigner of the issue.
    • If there are merge conflicts, run git rebase as opposed to git merge with master.

@nikotj1 nikotj1 requested review from preetpatel and TCHE614 April 20, 2020 02:56
@jordansimsmith
Copy link
Contributor

@preetpatel could you have a look at this please, I believe you recently changed this logic.

Copy link
Contributor

@Kalashnikkov Kalashnikkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, questionable about the comprehensive testing to be done, but if you can verify via a screenshot or something that'll be good! Nice work!

@nikotj1
Copy link
Contributor Author

nikotj1 commented Apr 20, 2020

LGTM, questionable about the comprehensive testing to be done, but if you can verify via a screenshot or something that'll be good! Nice work!

Thanks for the suggestion, screenshot attached:
image

Copy link
Contributor

@KimberleyEvans-Parker KimberleyEvans-Parker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the idea of the task manager was to put in the tasks in the earliest coming up free time so that you could complete the task as early as possible. Correct me if I'm wrong, but right now this PR is looking like it gets added after the due date and time of the task - not particularly helpful if you have an asignment due then.
Maybe it would be better to add in another input stating the start after date, specifying that you're only able to start the task after this date (so if I could only start it tomorrow, I'd specify tomorrow in the start after input and the task would then be made at that time

@nikotj1
Copy link
Contributor Author

nikotj1 commented Apr 21, 2020

I thought the idea of the task manager was to put in the tasks in the earliest coming up free time so that you could complete the task as early as possible. Correct me if I'm wrong, but right now this PR is looking like it gets added after the due date and time of the task - not particularly helpful if you have an asignment due then.
Maybe it would be better to add in another input stating the start after date, specifying that you're only able to start the task after this date (so if I could only start it tomorrow, I'd specify tomorrow in the start after input and the task would then be made at that time

I genuinely misunderstood the application and perhaps the related issue could be improved, my bad.

I'm thinking of adding an extra field of earliest start time that would fulfill the same spirit of the related issue. I have created the new issue at #268

@nikotj1 nikotj1 closed this Apr 21, 2020
@rmoradc rmoradc mentioned this pull request Apr 25, 2020
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add a new task on a selected date
4 participants