Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #257

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Update README.md #257

merged 5 commits into from
Oct 9, 2024

Conversation

gsouf
Copy link
Contributor

@gsouf gsouf commented Oct 5, 2024

Examples from the readme did not work.

  • "props" should be "prop"
  • no options for uncompressed i/o, assuming they have been removed?

"props" should be "prop"
no options for uncompressed i/o
Copy link
Owner

@sd2k sd2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and fixing it! It looks like the -u flag was removed and made default, and the -d flag was added as its inverse, in 475a314. I made some suggestions in the README 👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
gsouf and others added 4 commits October 9, 2024 08:57
Co-authored-by: Ben Sully <[email protected]>
Co-authored-by: Ben Sully <[email protected]>
Co-authored-by: Ben Sully <[email protected]>
Co-authored-by: Ben Sully <[email protected]>
@gsouf
Copy link
Contributor Author

gsouf commented Oct 8, 2024

@sd2k Thanks for your review. Applied your fixes

@sd2k sd2k merged commit 4e8fb71 into sd2k:master Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants