-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md: fix quickstart links #2293
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mykaul The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@grzywin - I'm unsure if it fixes the problem, but I hope the links are correct now. Perhaps we need fully hyperlink to the documentation in docs.scylladb.com? @annastuchlik ? |
e2326d2
to
3afc882
Compare
@mykaul It looks good now. I checked your PR and links are working - except "Contributing Guide" which you are aware of and also one Slack channel link needs to be updated (I wrote about it in the code review). |
@mykaul @annastuchlik IMHO, it could also be beneficial for the clients to include a link to the basic-setup URL in the README.md file. It provides a great explanation of how the basic configuration of the Operator and Scylla should look. The only thing that could be tweaked there is information about requirements regarding initial K8s configuration and some extra comment about NodeConfig configuration as the example in run.sh is doing it in GKE and we have also examples for EKS and Generic. |
It defeats the entire effort of the docs explaining the architecture and different configuration options. With the recording people are just going to run the script. As you correctly pointed out it's also platform specific. |
But this is unrelated to this PR? |
Fixes: scylladb#2270 In addition, renamed Scylla to ScyllaDB when needed. Signed-off-by: Yaniv Kaul <[email protected]>
Yes, this is unrelated (it is about basic-setup script), I just thought it is worth to mention about this here.
Well, you are right – the Operator is intended for more experienced users who understand the architecture, so the documentation should be the main source of information. However, if someone wants to experiment a bit, this shortcut to the basic setup could make things easier for them. Anyway, it was just a loose thought – you guys know the audience better than I do. |
IMO yes, it's a better experience than just opening the markdown file in github. @mykaul can you also please update the PR title and commit subject line to use the imperative mood? https://cbea.ms/git-commit/#imperative (it should be mentioned in the contribution guide which we currently don't have) |
Fixes: #2270
Description of your changes:
Fixes README links to quickstarts
Which issue is resolved by this Pull Request:
Resolves 2270