Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: fix quickstart links #2293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mykaul
Copy link
Contributor

@mykaul mykaul commented Dec 26, 2024

Fixes: #2270

Description of your changes:
Fixes README links to quickstarts

Which issue is resolved by this Pull Request:
Resolves 2270

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mykaul
Once this PR has been reviewed and has the lgtm label, please assign zimnx for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 26, 2024
@mykaul
Copy link
Contributor Author

mykaul commented Dec 26, 2024

@grzywin - I'm unsure if it fixes the problem, but I hope the links are correct now. Perhaps we need fully hyperlink to the documentation in docs.scylladb.com? @annastuchlik ?

@mykaul mykaul requested a review from annastuchlik December 26, 2024 10:01
@mykaul mykaul force-pushed the README_fixes branch 2 times, most recently from e2326d2 to 3afc882 Compare December 26, 2024 10:28
@scylla-operator-bot scylla-operator-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 26, 2024
@grzywin grzywin self-requested a review December 27, 2024 08:41
README.md Outdated Show resolved Hide resolved
@grzywin
Copy link

grzywin commented Dec 27, 2024

@grzywin - I'm unsure if it fixes the problem, but I hope the links are correct now. Perhaps we need fully hyperlink to the documentation in docs.scylladb.com? @annastuchlik ?

@mykaul It looks good now. I checked your PR and links are working - except "Contributing Guide" which you are aware of and also one Slack channel link needs to be updated (I wrote about it in the code review).

@grzywin
Copy link

grzywin commented Dec 27, 2024

@mykaul @annastuchlik IMHO, it could also be beneficial for the clients to include a link to the basic-setup URL in the README.md file. It provides a great explanation of how the basic configuration of the Operator and Scylla should look.
https://github.com/scylladb/scylla-operator/blob/master/recordings/basic-setup/run.sh

The only thing that could be tweaked there is information about requirements regarding initial K8s configuration and some extra comment about NodeConfig configuration as the example in run.sh is doing it in GKE and we have also examples for EKS and Generic.

@rzetelskik
Copy link
Member

IMHO, it could also be beneficial for the clients to include a link to the basic-setup URL in the README.md file. It provides a great explanation of how the basic configuration of the Operator and Scylla should look.
https://github.com/scylladb/scylla-operator/blob/master/recordings/basic-setup/run.sh

It defeats the entire effort of the docs explaining the architecture and different configuration options. With the recording people are just going to run the script. As you correctly pointed out it's also platform specific.

@mykaul
Copy link
Contributor Author

mykaul commented Dec 29, 2024

@mykaul @annastuchlik IMHO, it could also be beneficial for the clients to include a link to the basic-setup URL in the README.md file. It provides a great explanation of how the basic configuration of the Operator and Scylla should look. https://github.com/scylladb/scylla-operator/blob/master/recordings/basic-setup/run.sh

The only thing that could be tweaked there is information about requirements regarding initial K8s configuration and some extra comment about NodeConfig configuration as the example in run.sh is doing it in GKE and we have also examples for EKS and Generic.

But this is unrelated to this PR?

Fixes: scylladb#2270

In addition, renamed Scylla to ScyllaDB when needed.

Signed-off-by: Yaniv Kaul <[email protected]>
@grzywin
Copy link

grzywin commented Dec 30, 2024

But this is unrelated to this PR?

Yes, this is unrelated (it is about basic-setup script), I just thought it is worth to mention about this here.

It defeats the entire effort of the docs explaining the architecture and different configuration options. With the recording people are just going to run the script. As you correctly pointed out it's also platform specific.

Well, you are right – the Operator is intended for more experienced users who understand the architecture, so the documentation should be the main source of information. However, if someone wants to experiment a bit, this shortcut to the basic setup could make things easier for them. Anyway, it was just a loose thought – you guys know the audience better than I do.

@rzetelskik
Copy link
Member

Perhaps we need fully hyperlink to the documentation in docs.scylladb.com?

IMO yes, it's a better experience than just opening the markdown file in github.

@mykaul can you also please update the PR title and commit subject line to use the imperative mood? https://cbea.ms/git-commit/#imperative (it should be mentioned in the contribution guide which we currently don't have)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead links in README.md for 1.15 release
3 participants