-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs theme to 1.8 #2132
Update docs theme to 1.8 #2132
Conversation
Hi @dgarcia360. Thanks for your PR. I'm waiting for a scylladb member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind machinery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgarcia360 thanks for the PR!
The tests are failing with
The Poetry configuration is invalid:
- Additional properties are not allowed ('package-mode' was unexpected)
so that's something that needs looking into. Edit: I updated the images in our CI, passing now.
Please update the commit and PR title to describe the change using the verb in a base form, like "Update docs theme to 1.8". Our contribution guide is outdated - sorry! We're working on updating it just now.
we'll need to update our CI first as we're at poetry 1.5 |
Poetry image has been updated. Edit:
Python version in the image needs updating as well... |
Python was updated to |
Deleted the dependabot file, we can discuss if we want to include it as part of a separate issue
Done! |
1cb3aea
to
419bbbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/assign rzetelskik
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgarcia360, rzetelskik, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related issue scylladb/sphinx-scylladb-theme#1229
ScyllaDB Sphinx Theme 1.8 is out 🥳!
Here's a summary of changes:
poetry.lock
file to ensure consistent dependencies in your CI/CD pipeline.You can read more about all the notable changes here.
How to test this PR
Clone this PR.
Enter the docs folder, and run:
Open http://localhost:5500 in your browser. The doc should render without errors, and the version should be Sphinx Theme version (see the footer) must be
1.8.x
: