Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds gcp metadata provider support to cloudmeta package #4155

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

VAveryanov8
Copy link
Collaborator

@VAveryanov8 VAveryanov8 commented Dec 11, 2024

This adds gcp metadata provider support to cloudmeta package.

This changes has been manually tested on gcp node in lab env.

Fixes: #4128

P.S. retries are handled by gcp sdk, here is the note from documentation of GetWithContext(...)method.

Without an extra deadline in the context this call can take in the worst case, with internal backoff retries, up to 15 seconds (e.g. when server is responding slowly). Pass context with additional timeouts when needed.

Please make sure that:

  • Code is split to commits that address a single change
  • Commit messages are informative
  • Commit titles have module prefix
  • Commit titles have issue nr. suffix

@VAveryanov8
Copy link
Collaborator Author

This pr depends on #4154

@VAveryanov8 VAveryanov8 marked this pull request as ready for review December 11, 2024 13:03
@VAveryanov8 VAveryanov8 self-assigned this Dec 11, 2024
Base automatically changed from va/cloudmeta-aws to master December 13, 2024 12:43
@VAveryanov8 VAveryanov8 force-pushed the va/cloudmeta-gcp-provider branch from 7d6bb37 to 700395c Compare December 13, 2024 12:54
pkg/cloudmeta/metadata.go Outdated Show resolved Hide resolved
pkg/cloudmeta/gcp.go Outdated Show resolved Hide resolved
pkg/cloudmeta/gcp.go Outdated Show resolved Hide resolved
pkg/cloudmeta/gcp.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@Michal-Leszczynski Michal-Leszczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VAveryanov8 VAveryanov8 merged commit 0372277 into master Dec 17, 2024
51 checks passed
@VAveryanov8 VAveryanov8 deleted the va/cloudmeta-gcp-provider branch December 17, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to query instance metadata on GCP
3 participants