Test writing h5ad in Python & in R #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcannood
requested changes
Dec 19, 2024
| @@ -0,0 +1,64 @@ | |||
| # python, R | |||
| # does not test numeric_dense, numeric_dense_with_nas or integer_dense | |||
There was a problem hiding this comment.
Could you elaborate why not?
There was a problem hiding this comment.
Because of issue #198
It might be better to just document this in the known_issues.yaml though
Comment on lines
139
to
141
| # nolint start | ||
| for( r_name in r_datatypes){ | ||
| test_that(paste0("Comparing a python generated .h5ad with obsm and varm '", name, |
There was a problem hiding this comment.
Why do you use nolint start here?
Please reformat 🙇 You can use styler::style_pkg() if you like
Suggested change
| # nolint start | |
| for( r_name in r_datatypes){ | |
| test_that(paste0("Comparing a python generated .h5ad with obsm and varm '", name, | |
| for (r_name in r_datatypes) { | |
| test_that(paste0("Comparing a python generated .h5ad with obsm and varm '", name, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests the writing of various anndata slots. Compares what gets written in Python with what gets written in R.