-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix): lazy chunking respects -1 #1743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ilan-gold
commented
Nov 7, 2024
•
edited
Loading
edited
- Noticed while creating the screenshot tutorial for the announcement
- Tests added
- Release note added (or unnecessary)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1743 +/- ##
==========================================
- Coverage 86.99% 84.52% -2.48%
==========================================
Files 40 40
Lines 6053 6053
==========================================
- Hits 5266 5116 -150
- Misses 787 937 +150
|
ilan-gold
force-pushed
the
ig/fix_chunking
branch
from
November 8, 2024 08:41
a6906a9
to
be4be30
Compare
ilan-gold
changed the title
(fix): lazy chunking respects -1 + proper
(fix): lazy chunking respects -1
Nov 8, 2024
data
/indices
caching
flying-sheep
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, just one minor code style issue
meeseeksmachine
pushed a commit
to meeseeksmachine/anndata
that referenced
this pull request
Nov 8, 2024
ilan-gold
added a commit
that referenced
this pull request
Nov 11, 2024
Co-authored-by: Ilan Gold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.